microshift icon indicating copy to clipboard operation
microshift copied to clipboard

[release-4.15] OCPBUGS-29246: Create microshift-olm-release-info RPM

Open pmtk opened this issue 1 year ago • 8 comments

Creates new dedicated RPM for OLM's release info that depends on microshift-release-info

pmtk avatar Feb 08 '24 15:02 pmtk

@pmtk: This pull request references Jira Issue OCPBUGS-29246, which is invalid:

  • expected Jira Issue OCPBUGS-29246 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Creates new dedicated RPM for OLM's release info that depends on microshift-release-info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 08 '24 15:02 openshift-ci-robot

/hold targeting 4.15.Z

pmtk avatar Feb 08 '24 15:02 pmtk

/jira refresh

pmtk avatar Feb 08 '24 15:02 pmtk

@pmtk: This pull request references Jira Issue OCPBUGS-29246, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 08 '24 15:02 openshift-ci-robot

/jira refresh

pmtk avatar Feb 08 '24 15:02 pmtk

@pmtk: This pull request references Jira Issue OCPBUGS-29246, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27849 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-27849 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact: /cc @jogeo

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 08 '24 15:02 openshift-ci-robot

/unhold /retest

pmtk avatar Feb 28 '24 11:02 pmtk

/test microshift-metal-tests

pmtk avatar Feb 28 '24 12:02 pmtk

When did we decide we wanted this in the Z release? I thought we were just going to do it for 4.16.

dhellmann avatar Feb 29 '24 16:02 dhellmann

When did we decide we wanted this in the Z release? I thought we were just going to do it for 4.16.

Arch call Jan 23: "We strive to fix this for existing components (e.g. microshift-olm), maybe in Z or next release."

I thought we want to realign this as soon as possible (4.15.1)

pmtk avatar Mar 01 '24 09:03 pmtk

When did we decide we wanted this in the Z release? I thought we were just going to do it for 4.16.

Arch call Jan 23: "We strive to fix this for existing components (e.g. microshift-olm), maybe in Z or next release."

I thought we want to realign this as soon as possible (4.15.1)

Are all of the changes to the release pipeline ready to go, too? If we have an extra RPM that the release pipeline isn't aware of, it will trigger a warning on the errata. I think we could release anyway, but we might have to take some manual steps.

dhellmann avatar Mar 01 '24 14:03 dhellmann

/lgtm /label backport-risk-assessed

/hold

Based on our discussion on slack, it sounds like you have everything lined up and ready to go. I left a hold in case you need to coordinate anything synchronously, so remove that when you're ready to merge.

dhellmann avatar Mar 01 '24 18:03 dhellmann

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 01 '24 18:03 openshift-ci[bot]

I think we are ready to merge this change. @jogeo , please add the label if QE approves this. After it's merged, we need to open a ticket to fix the errata.

/unhold

ggiguash avatar Mar 03 '24 11:03 ggiguash

/label cherry-pick-approved

jogeo avatar Mar 06 '24 14:03 jogeo

/retest-required

Remaining retests: 0 against base HEAD 19e9ce47ab737fb994917093434d09f02a574946 and 2 for PR HEAD da244dcbe543b82be44e996b6a914403af751bb6 in total

openshift-ci-robot avatar Mar 06 '24 15:03 openshift-ci-robot

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 06 '24 18:03 openshift-ci[bot]

@pmtk: Jira Issue OCPBUGS-29246: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29246 has been moved to the MODIFIED state.

In response to this:

Creates new dedicated RPM for OLM's release info that depends on microshift-release-info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 06 '24 18:03 openshift-ci-robot