microshift icon indicating copy to clipboard operation
microshift copied to clipboard

Test for OCP-63099

Open dhensel-rh opened this issue 2 years ago • 15 comments

Which issue(s) this PR addresses:

Closes #<Issue Number>

dhensel-rh avatar Nov 06 '23 21:11 dhensel-rh

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Nov 06 '23 21:11 openshift-ci[bot]

/retest

dhensel-rh avatar Nov 08 '23 17:11 dhensel-rh

/retest

dhensel-rh avatar Nov 08 '23 20:11 dhensel-rh

/test verify

dhensel-rh avatar Nov 09 '23 16:11 dhensel-rh

/retest

dhensel-rh avatar Nov 10 '23 13:11 dhensel-rh

/retest

dhensel-rh avatar Nov 16 '23 14:11 dhensel-rh

It looks like this PR is changing files that would be updated by running the microshift rebase script. Is that intentional, or a side-effect of something in your git repo?

dhellmann avatar Nov 16 '23 22:11 dhellmann

It looks like this PR is changing files that would be updated by running the microshift rebase script. Is that intentional, or a side-effect of something in your git repo?

I am trying to add one file. This must be something in my git repo. I attempted a rebase yesterday. I wonder if I did something incorrectly.

dhensel-rh avatar Nov 17 '23 13:11 dhensel-rh

/retest

dhensel-rh avatar Nov 17 '23 14:11 dhensel-rh

/retest

dhensel-rh avatar Dec 20 '23 13:12 dhensel-rh

@dhensel-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 03 '24 15:01 openshift-ci[bot]

This looks good. There are some similar tests in https://github.com/openshift/microshift/blob/main/test/suites/standard/configuration.robot so maybe the 2 suites can be combined here into this new file?

I'll approve the PR as something we want. We should give another member of the team a chance to review it and lgtm it.

/approve

dhellmann avatar Jan 03 '24 20:01 dhellmann

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, dhensel-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jan 03 '24 20:01 openshift-ci[bot]

This looks good. There are some similar tests in https://github.com/openshift/microshift/blob/main/test/suites/standard/configuration.robot so maybe the 2 suites can be combined here into this new file?

Now that https://github.com/openshift/microshift/pull/2832 has merged, you probably want to rebase this before considering how to combine the 2 suites.

dhellmann avatar Jan 05 '24 19:01 dhellmann

This looks good. There are some similar tests in https://github.com/openshift/microshift/blob/main/test/suites/standard/configuration.robot so maybe the 2 suites can be combined here into this new file?

Now that #2832 has merged, you probably want to rebase this before considering how to combine the 2 suites.

Thanks. I'll rebase and have a look at combining the 2 suites.

dhensel-rh avatar Jan 05 '24 19:01 dhensel-rh