managed-upgrade-operator icon indicating copy to clipboard operation
managed-upgrade-operator copied to clipboard

mockgen deprecated: use uber-go/mock instead

Open sebrandon1 opened this issue 2 months ago • 4 comments

https://github.com/golang/mock is marked as archived as of June 27, 2023. They recommend using go.uber.org/mock.

This PR attempts to change the dependency to one that is maintained.

Tracking issue: https://github.com/redhat-best-practices-for-k8s/telco-bot/issues/45

sebrandon1 avatar Nov 13 '25 18:11 sebrandon1

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1 Once this PR has been reviewed and has the lgtm label, please assign clcollins for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 13 '25 18:11 openshift-ci[bot]

Codecov Report

:x: Patch coverage is 75.00000% with 36 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.35%. Comparing base (db79ec6) to head (2d4374d).

Files with missing lines Patch % Lines
...kg/alertmanager/mocks/alertManagerSilenceClient.go 60.00% 8 Missing :warning:
pkg/metrics/mocks/metrics.go 50.00% 8 Missing :warning:
pkg/maintenance/mocks/maintenance.go 66.66% 4 Missing :warning:
pkg/ocm/mocks/builder.go 0.00% 4 Missing :warning:
pkg/ocm/mocks/client.go 75.00% 4 Missing :warning:
pkg/ocmagent/mocks/builder.go 0.00% 4 Missing :warning:
...upgradeconfigmanager/mocks/upgradeconfigmanager.go 0.00% 4 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #561   +/-   ##
=======================================
  Coverage   54.35%   54.35%           
=======================================
  Files         123      123           
  Lines        6123     6123           
=======================================
  Hits         3328     3328           
  Misses       2592     2592           
  Partials      203      203           
Files with missing lines Coverage Δ
mocks/builder.go 0.00% <ø> (ø)
mocks/client.go 0.00% <ø> (ø)
pkg/alertmanager/alertManagerSilenceClient.go 0.00% <ø> (ø)
pkg/availabilitychecks/availabilitychecks.go 0.00% <ø> (ø)
...availabilitychecks/mocks/mockAvailabilityChecks.go 100.00% <ø> (ø)
pkg/clusterversion/mocks/mockClusterVersion.go 100.00% <100.00%> (ø)
.../clusterversion/mocks/mockClusterVersionBuilder.go 100.00% <ø> (ø)
pkg/configmanager/config.go 0.00% <ø> (ø)
pkg/configmanager/mocks/configmanager.go 100.00% <ø> (ø)
pkg/configmanager/mocks/configmanagerbuilder.go 100.00% <ø> (ø)
... and 34 more
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Nov 13 '25 18:11 codecov-commenter

/retest

tkong-redhat avatar Nov 17 '25 21:11 tkong-redhat

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate 2d4374d818e6e3e76c8c0f64852345a98555941d link true /test validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 17 '25 21:11 openshift-ci[bot]