console
console copied to clipboard
openshift
CONSOLE-2225: Revise container details page layout
Changes in this PR:
- The properties at the top only use 2 columns instead of 3 and the tables at the bottom stack, spanning the full width of the page. Changes line with current layout on pod details page.
/hold /assign @ahardin-rh @rhamilto @spadgett @yapei
Code changes look good. A screenshot and/or video showing the layout is recommended.
@maudem: The /test command needs one or more targets.
The following commands are available to trigger required jobs:
-
/test analyze -
/test backend -
/test ceph-storage-plugin -
/test e2e-gcp-console -
/test frontend -
/test images -
/test kubevirt-plugin
Use /test all to run the following jobs that were automatically triggered:
-
pull-ci-openshift-console-master-analyze -
pull-ci-openshift-console-master-backend -
pull-ci-openshift-console-master-e2e-gcp-console -
pull-ci-openshift-console-master-frontend -
pull-ci-openshift-console-master-images
In response to this:
/test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/assign @yapei @ahardin-rh @sferich888 for approvals
This is a minor change to the container page layout that moves it to a two column layout instead of three.
@maudem: The /test command needs one or more targets.
The following commands are available to trigger required jobs:
-
/test analyze -
/test backend -
/test ceph-storage-plugin -
/test e2e-gcp-console -
/test frontend -
/test images -
/test kubevirt-plugin
Use /test all to run the following jobs that were automatically triggered:
-
pull-ci-openshift-console-master-analyze -
pull-ci-openshift-console-master-backend -
pull-ci-openshift-console-master-e2e-gcp-console -
pull-ci-openshift-console-master-frontend -
pull-ci-openshift-console-master-images
In response to this:
/test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Sorry I missed the message requiring QE approving, @XiyunZhao will test it today!
This PR has been verified on the private build, and the layout is as same as the shared design.
But I have a question about the indentation of the line after comparison with the Pod details page @maudem Seems the current change is little different from the other pages, is that correct?
This PR has been verified on the private build, and the layout is as same as the shared design. But I have a question about the indentation of the line after comparison with the Pod details page @maudem Seems the current change is little different from the other pages, is that correct?
@XiyunZhao Thank you for catching that. I'll tweak the layout and ping you when I'm done.
@XiyunZhao @spadgett @dtaylor113 My code has changed, can you please look it over again?
New changes have been verified on the private build, the layout of the Pods container page is as same as other pages now
@maudem, I notice this PR includes 3 commits. Is that intentional? Ideally, this would be squashed to a single commit.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dtaylor113, maudem, spadgett, XiyunZhao, zherman0
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [spadgett]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
