console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-69647: icon is missing from Console plugins list table

Open krishagarwal278 opened this issue 3 weeks ago โ€ข 6 comments

Fixed Status capitalization issue so Status component can recognize icons

krishagarwal278 avatar Dec 17 '25 13:12 krishagarwal278

@krishagarwal278: This pull request references Jira Issue OCPBUGS-69647, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixed Status capitalization issue so Status component can recognize icons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 17 '25 13:12 openshift-ci-robot

Walkthrough

Updated ConsoleOperatorConfig.tsx to render the ConsolePluginStatus value with its first character uppercased (e.g., "failed" โ†’ "Failed") while keeping the existing conditional errorMessage as the title when status is "failed". No public types or signatures changed.

Changes

Cohort / File(s) Summary
Status rendering enhancement
frontend/packages/console-app/src/components/console-operator/ConsoleOperatorConfig.tsx
Rendered ConsolePluginStatus by capitalizing the status string's first character; retained conditional errorMessage as the title when status equals "failed". No public API changes.

Estimated code review effort

๐ŸŽฏ 2 (Simple) | โฑ๏ธ ~10 minutes

  • Single-file, localized UI change with low logic density.
  • Review attention:
    • Verify casing across all possible status values and any downstream display/consumers.
    • Confirm errorMessage remains correctly applied as title when status is "failed".
    • Check for i18n/translation implications if status strings are localized.
โœจ Finishing touches
  • [ ] ๐Ÿ“ Generate docstrings
๐Ÿงช Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

๐Ÿ“œ Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 58c1bf091c42501573897abb767b75e51add145d and e8500e73d34f2679e9e2ed0d3dcf8368dad14d20.

๐Ÿ“’ Files selected for processing (1)
  • frontend/packages/console-app/src/components/console-operator/ConsoleOperatorConfig.tsx
๐Ÿงฐ Additional context used
๐Ÿ““ Path-based instructions (1)
**

โš™๏ธ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • frontend/packages/console-app/src/components/console-operator/ConsoleOperatorConfig.tsx
๐Ÿ”‡ Additional comments (1)
frontend/packages/console-app/src/components/console-operator/ConsoleOperatorConfig.tsx (1)

91-96: LGTM! The capitalization fix correctly addresses the icon display issue.

The string manipulation safely transforms status values (e.g., "failed" โ†’ "Failed") for the Status component, and the conditional logic on line 94 correctly checks the original lowercase value. This aligns with the PR objective to fix missing icons in the Console plugins list table.

Verify that the status icons now display correctly in the Console plugins list table for all three states: "Pending", "Loaded", and "Failed".


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 17 '25 13:12 coderabbitai[bot]

/jira refresh

krishagarwal278 avatar Dec 17 '25 13:12 krishagarwal278

@krishagarwal278: This pull request references Jira Issue OCPBUGS-69647, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 17 '25 13:12 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishagarwal278, logonoff, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Dec 17 '25 19:12 openshift-ci[bot]

/retest

krishagarwal278 avatar Dec 18 '25 08:12 krishagarwal278

/retest

krishagarwal278 avatar Dec 18 '25 10:12 krishagarwal278

/retest

krishagarwal278 avatar Dec 22 '25 06:12 krishagarwal278

/test e2e-gcp-console

rhamilto avatar Dec 22 '25 13:12 rhamilto

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Dec 22 '25 18:12 openshift-ci[bot]

/retest

krishagarwal278 avatar Dec 22 '25 19:12 krishagarwal278

/retest

krishagarwal278 avatar Dec 23 '25 14:12 krishagarwal278

/retest

krishagarwal278 avatar Dec 23 '25 19:12 krishagarwal278

@krishagarwal278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console e8500e73d34f2679e9e2ed0d3dcf8368dad14d20 link true /test e2e-gcp-console
ci/prow/okd-scos-images e8500e73d34f2679e9e2ed0d3dcf8368dad14d20 link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Dec 23 '25 23:12 openshift-ci[bot]