console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-63237: There should be no role ARN field as token-auth-aws/azure/gcp=false in csv annotations

Open cajieh opened this issue 1 month ago • 25 comments

Before:

Screenshot 2025-12-09 at 2 16 36 PM

After

Screenshot 2025-12-09 at 2 16 41 PM

cajieh avatar Dec 05 '25 17:12 cajieh

@cajieh: This pull request references Jira Issue OCPBUGS-63237, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/hold Need to verify this change on AWS STS enabled cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 05 '25 17:12 openshift-ci-robot

[!IMPORTANT]

Review skipped

Auto reviews are limited based on label configuration.

:no_entry_sign: Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 05 '25 17:12 coderabbitai[bot]

Checked on sts cluster with the pr code, when operator annotations containing token-auth-aws/azure/gcp=false, on operator install page, there is not cloud credential related required field. before: Screenshot from 2025-12-08 16-02-56 after: Screenshot from 2025-12-08 16-02-40 /verified by yanpzhan

yanpzhan avatar Dec 08 '25 08:12 yanpzhan

@yanpzhan: This PR has been marked as verified by yanpzhan.

In response to this:

Checked on sts cluster with the pr code, when operator annotations containing token-auth-aws/azure/gcp=false, on operator install page, there is not cloud credential related required field. before: Screenshot from 2025-12-08 16-02-56 after: Screenshot from 2025-12-08 16-02-40 /verified by yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 08 '25 08:12 openshift-ci-robot

/retest-required

Leo6Leo avatar Dec 08 '25 14:12 Leo6Leo

@cajieh: This pull request references Jira Issue OCPBUGS-63237, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Before:

Screenshot 2025-12-09 at 2 16 36 PM

After

Screenshot 2025-12-09 at 2 16 41 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 09 '25 19:12 openshift-ci-robot

/test backend

cajieh avatar Dec 11 '25 12:12 cajieh

/retest-required

Leo6Leo avatar Dec 12 '25 14:12 Leo6Leo

/test e2e-gcp-console

cajieh avatar Dec 15 '25 09:12 cajieh

/jira refresh

cajieh avatar Dec 15 '25 09:12 cajieh

@cajieh: This pull request references Jira Issue OCPBUGS-63237, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 15 '25 09:12 openshift-ci-robot

/verified later @yanpzhan /label acknowledge-critical-fixes-only

cajieh avatar Dec 15 '25 09:12 cajieh

@cajieh: This PR has been marked to be verified later by @yanpzhan.

In response to this:

/verified later @yanpzhan /label acknowledge-critical-fixes-only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 15 '25 09:12 openshift-ci-robot

/test e2e-gcp-console

cajieh avatar Dec 16 '25 14:12 cajieh

/lgtm

jhadvig avatar Dec 16 '25 15:12 jhadvig

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Dec 16 '25 15:12 openshift-ci[bot]

/unhold

cajieh avatar Dec 16 '25 16:12 cajieh

/retest

cajieh avatar Dec 16 '25 16:12 cajieh

/retest-required

Remaining retests: 0 against base HEAD 19b01f06cb8106dfe21ca3cc12dd5376a5935e39 and 2 for PR HEAD ed4d16dd870019afc355158f551e5ac8637d9e99 in total

openshift-ci-robot avatar Dec 16 '25 21:12 openshift-ci-robot

/retest

cajieh avatar Dec 16 '25 23:12 cajieh

/test okd-scos-images

lunarwhite avatar Dec 17 '25 04:12 lunarwhite

/test okd-scos-images

cajieh avatar Dec 17 '25 11:12 cajieh

/test okd-scos-images

cajieh avatar Dec 17 '25 11:12 cajieh

/retest-required

Remaining retests: 0 against base HEAD 9ac9e36e6bca30bd2b7f84752cc588f4cb842b44 and 1 for PR HEAD ed4d16dd870019afc355158f551e5ac8637d9e99 in total

openshift-ci-robot avatar Dec 17 '25 16:12 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD d3b540a070b976f490eb3259f963703f4c33200d and 0 for PR HEAD ed4d16dd870019afc355158f551e5ac8637d9e99 in total

openshift-ci-robot avatar Dec 18 '25 18:12 openshift-ci-robot

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Dec 18 '25 19:12 openshift-ci[bot]

@cajieh: Jira Issue OCPBUGS-63237: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-63237 has been moved to the MODIFIED state.

In response to this:

Before:

Screenshot 2025-12-09 at 2 16 36 PM

After

Screenshot 2025-12-09 at 2 16 41 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 19 '25 04:12 openshift-ci-robot

@cajieh: new pull request created: #15869

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/cherry-pick release-4.21

cajieh avatar Dec 19 '25 09:12 cajieh

@cajieh: new pull request created: #15870

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.