openshift
OCPBUGS-65946: Fix search component to not pass ALL_NAMESPACES_KEY to…
@TheRealJon: This pull request references Jira Issue OCPBUGS-65946, which is invalid:
- expected the bug to target the "4.21.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
… the AsyncComponent
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Walkthrough
Adjusted namespace handling in the search component to treat the all-namespaces sentinel as undefined for the AsyncComponent loader; updated Cypress integration tests to use the data-view (dv) API, re-enable tests, and add assertions about namespace visibility in search results.
Changes
| Cohort / File(s) | Change Summary |
|---|---|
Namespace handling change frontend/public/components/search.tsx |
Imported ALL_NAMESPACES_KEY and modified the AsyncComponent loader namespace prop to map ALL_NAMESPACES_KEY to undefined, altering how all-namespaces requests are represented. |
Integration test updates frontend/packages/integration-tests-cypress/tests/app/filtering-and-searching.cy.ts |
Introduced SEARCH_NAMESPACE and SEARCH_DEPLOYMENT_NAME constants; replaced listPage.rows with listPage.dvRows, listPage.dvFilter and related dv assertions; changed expected counts to use countShouldBe(3); re-enabled tests (xit → it); added tests verifying namespace visibility in search results for "All Namespaces" vs specific namespace. |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
- Reason: small component logic change plus several test API migrations and new tests require verifying test behavior.
- Pay attention to:
- Correct mapping of
ALL_NAMESPACES_KEY→undefinedin all loader call sites. - Test updates using
dvAPIs and new assertions for namespace visibility.
- Correct mapping of
✨ Finishing touches
- [ ] 📝 Generate docstrings
🧪 Generate unit tests (beta)
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot] avatar](https://avatars.githubusercontent.com/in/347564?v=4 "Published by a pub.dev verified publisher"){kind=small}
@TheRealJon: This pull request references Jira Issue OCPBUGS-65946, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.21.0) matches configured target version for branch (4.21.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
@openshift-bot: This pull request references Jira Issue OCPBUGS-65946, which is invalid:
- expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/lgtm cancel
Please add the test updates from https://github.com/openshift/console/pull/15826/files#diff-8a164ce7ed5a6df090a10cb8c9d42e3cebdecea9c5b6423a556e399dd42445b7
@vikram-raj: This pull request references Jira Issue OCPBUGS-65946, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.22.0) matches configured target version for branch (4.22.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: TheRealJon, vikram-raj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [TheRealJon,vikram-raj]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
@openshift-bot: This pull request references Jira Issue OCPBUGS-65946, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.22.0) matches configured target version for branch (4.22.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Before the fix: searching some resources with All Projects will return 404
After the fix: resources in all namespaces can be returned successfully
/verified by @yapei
@yapei: This PR has been marked as verified by @yapei.
In response to this:
Before the fix: searching some resources with
All Projectswill return 404After the fix: resources in all namespaces can be returned successfully
/verified by @yapei
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD d00353d166cbb752ddfcde940ed2c4d62a33521c and 2 for PR HEAD 2765cdbb06d4af55117959a49be6cd8ffa0cf56f in total
/retest-required
Remaining retests: 0 against base HEAD 9c70ba0e0f17e4a9f037f79768fc7cc2a07ccf3b and 1 for PR HEAD 2765cdbb06d4af55117959a49be6cd8ffa0cf56f in total
/retest-required
Remaining retests: 0 against base HEAD 255260298373cbcc0357a851767c56b3985c3b66 and 0 for PR HEAD 2765cdbb06d4af55117959a49be6cd8ffa0cf56f in total
/hold
Revision 2765cdbb06d4af55117959a49be6cd8ffa0cf56f was retested 3 times: holding
@TheRealJon: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
