CONSOLE-4844: merge secret scenarios
Merge downstream case OCP-47010&OCP-54014 into upstream
- Added TLS and JKS secret files
- Added new test file
from -yaml.cy.tsfor case OCP-47010 - Integrated OCP-54014 test steps into
key-value.cy.ts
For ticket: https://issues.redhat.com/browse/CONSOLE-4844
@yapei Kindly help to review
we need update title
CONSOLE-4844: merge secret scenarios
@XiyunZhao: This pull request references CONSOLE-4844 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.
In response to this:
Merge downstream case OCP-47010&OCP-54014 into upstream
- Added TLS and JKS secret files
- Added new test file
from -yaml.cy.tsfor case OCP-47010- Integrated OCP-54014 test steps into
key-value.cy.tsFor ticket: https://issues.redhat.com/browse/CONSOLE-4844
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
looks good from my point of view... thanks for the updates!!! waiting for engineering team feedback
Hi @jhadvig, Kindly help to review this Pull Request
Walkthrough
Introduces a new TLS secret workflow in Cypress integration tests, including TLS secret configuration constants and setup logic. Adds a test case for adding and verifying key/value pairs in TLS secrets. Includes two new helper methods in the secrets view module for managing key/value pairs.
Changes
| Cohort / File(s) | Summary |
|---|---|
TLS Secret Key/Value Workflowfrontend/packages/integration-tests-cypress/tests/crud/secrets/key-value.cy.ts, frontend/packages/integration-tests-cypress/views/secret.ts |
Introduces TLS secret YAML constants and setup logic to create TLS secrets in test namespace. Adds new test case that navigates to TLS secret edit page, adds a key/value pair, and verifies existence. Adds two new helper methods: addKeyValue() for UI interaction to add credentials and checkKeyValueExist() to reveal and assert key/value data on details page. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
- Verify TLS secret YAML format in constants is valid and properly escaped
- Confirm selector names (
secret-key,file-input-textarea,secret-data-term) match the actual UI elements - Ensure new test case properly waits for async operations before assertions
- Validate that new helper methods follow existing patterns and error handling in the view module
✨ Finishing touches
- [ ] 📝 Generate docstrings
🧪 Generate unit tests (beta)
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
Comment @coderabbitai help to get the list of available commands and usage tips.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, logonoff, XiyunZhao
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [jhadvig,logonoff]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/verified by CI
@logonoff: This PR has been marked as verified by CI.
In response to this:
/verified by CI
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD 99c3437a187d33c057466f99e6c2e3ef04f45422 and 2 for PR HEAD dcc373ef7e124da5f37b9bf8750e379b95ba2da4 in total
/retest-required
Remaining retests: 0 against base HEAD df5acf5f3f90b6ff34fef67cbb49ae7ee9bd7eae and 1 for PR HEAD dcc373ef7e124da5f37b9bf8750e379b95ba2da4 in total
/retest
/retest-required
Remaining retests: 0 against base HEAD 24830e32f72e7da9cb20fd34dd6be5c13fdf126e and 0 for PR HEAD dcc373ef7e124da5f37b9bf8750e379b95ba2da4 in total
@XiyunZhao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/okd-scos-images | dcc373ef7e124da5f37b9bf8750e379b95ba2da4 | link | true | /test okd-scos-images |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/hold
Revision dcc373ef7e124da5f37b9bf8750e379b95ba2da4 was retested 3 times: holding