console icon indicating copy to clipboard operation
console copied to clipboard

NO-JIRA: Add debug output for bridge flags

Open TheRealJon opened this issue 4 months ago • 9 comments

TheRealJon avatar Aug 20 '25 16:08 TheRealJon

@TheRealJon: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 20 '25 16:08 openshift-ci-robot

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Aug 20 '25 16:08 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 20 '25 16:08 openshift-ci[bot]

/retest

Mylanos avatar Aug 25 '25 09:08 Mylanos

@TheRealJon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn c371943c4f7790f44d946922770a003c3fa1e340 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 25 '25 13:08 openshift-ci[bot]

/test okd-scos-e2e-aws-ovn

XiyunZhao avatar Oct 16 '25 09:10 XiyunZhao

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Oct 16 '25 09:10 openshift-merge-robot

/verified by @XiyunZhao Tested this PR and focused on the following areas, and no issue was found:

  • Executed the command ./bin/bridge -v=value with different values. For v < 4: no notices or flag outputs are displayed. For v ≥ 4: the message “Running with flags” appears, followed by a list of all flags and their corresponding values, properly aligned in the --name value format.
  • Verified behavior with additional flags to ensure that all settings are displayed correctly according to their registry values. eg: ./bin/bridge -v=5 --i18n-namespaces=plugin__acm,plugin__kubevirt
  • Verified invalid value Command will exit with message "invalid value "" for flag -v: strconv.ParseInt: parsing "": invalid syntax" will return

Snapshot for testing: 15423_testing 15423_v3

XiyunZhao avatar Oct 17 '25 03:10 XiyunZhao

@XiyunZhao: This PR has been marked as verified by @XiyunZhao.

In response to this:

/verified by @XiyunZhao Tested this PR and focused on the following areas, and no issue was found:

  • Executed the command ./bin/bridge -v=value with different values. For v < 4: no notices or flag outputs are displayed. For v ≥ 4: the message “Running with flags” appears, followed by a list of all flags and their corresponding values, properly aligned in the --name value format.
  • Verified behavior with additional flags to ensure that all settings are displayed correctly according to their registry values. eg: ./bin/bridge -v=5 --i18n-namespaces=plugin__acm,plugin__kubevirt
  • Verified invalid value Command will exit with message "invalid value "" for flag -v: strconv.ParseInt: parsing "": invalid syntax" will return

Snapshot for testing: 15423_testing 15423_v3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 17 '25 03:10 openshift-ci-robot