console icon indicating copy to clipboard operation
console copied to clipboard

CONSOLE-4693: Enable strickNullCheck for packages/console-app/src/components/console-operator | dashboards-page | detect-namespace

Open krishagarwal278 opened this issue 4 months ago • 65 comments

krishagarwal278 avatar Aug 13 '25 20:08 krishagarwal278

@krishagarwal278: This pull request references CONSOLE-4693 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 13 '25 20:08 openshift-ci-robot

/label docs-approved /label px-approved

krishagarwal278 avatar Aug 13 '25 20:08 krishagarwal278

/assign @yanpzhan

krishagarwal278 avatar Aug 14 '25 17:08 krishagarwal278

/retest

jhadvig avatar Aug 15 '25 12:08 jhadvig

/retest

krishagarwal278 avatar Aug 18 '25 01:08 krishagarwal278

There is not regression issue for the pr. /label qe-approved

yanpzhan avatar Aug 18 '25 13:08 yanpzhan

@krishagarwal278: This pull request references CONSOLE-4693 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 18 '25 13:08 openshift-ci-robot

/label tide/merge-method-squash

krishagarwal278 avatar Aug 21 '25 19:08 krishagarwal278

/retest

krishagarwal278 avatar Aug 28 '25 19:08 krishagarwal278

/label acknowledge-critical-fixes-only

krishagarwal278 avatar Aug 28 '25 19:08 krishagarwal278

/retest

krishagarwal278 avatar Aug 28 '25 19:08 krishagarwal278

/retest

krishagarwal278 avatar Aug 29 '25 14:08 krishagarwal278

/retest

krishagarwal278 avatar Sep 01 '25 17:09 krishagarwal278

/retest

cajieh avatar Sep 03 '25 18:09 cajieh

/lgtm

cajieh avatar Sep 03 '25 18:09 cajieh

/retest

krishagarwal278 avatar Sep 04 '25 13:09 krishagarwal278

/retest

krishagarwal278 avatar Sep 05 '25 14:09 krishagarwal278

/label verified

vojtechszocs avatar Sep 05 '25 14:09 vojtechszocs

@vojtechszocs: The label(s) /label verified cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, plugin-api-approved, plugin-api-changed, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Sep 05 '25 14:09 openshift-ci[bot]

@krishagarwal278: This PR has been marked to be verified later by @yapei.

In response to this:

/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 05 '25 14:09 openshift-ci-robot

/verified later @yapei @yanpzhan

krishagarwal278 avatar Sep 05 '25 14:09 krishagarwal278

@krishagarwal278: This PR has been marked to be verified later by @yapei.

In response to this:

/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 05 '25 14:09 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 8719f8a40fabbea0d44db195b61c9cd289412bc0 and 2 for PR HEAD 40a773a75633d490b519ec1380d6f9e20fe7b796 in total

openshift-ci-robot avatar Sep 05 '25 18:09 openshift-ci-robot

/retest

jhadvig avatar Sep 08 '25 10:09 jhadvig

/verified later @yapei @yanpzhan

krishagarwal278 avatar Sep 08 '25 14:09 krishagarwal278

@krishagarwal278: This PR has been marked to be verified later by @yapei @yanpzhan.

In response to this:

/verified later @yapei @yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 08 '25 14:09 openshift-ci-robot

@krishagarwal278 Do we still need pre-merge verification?

yapei avatar Sep 09 '25 02:09 yapei

/retest

cajieh avatar Sep 10 '25 13:09 cajieh

/retest

cajieh avatar Sep 10 '25 13:09 cajieh

/lgtm

cajieh avatar Sep 10 '25 13:09 cajieh