console icon indicating copy to clipboard operation
console copied to clipboard

CONSOLE-4677: Enable strictNullChecks: true for frontend/insights-plugin and frontend/helm-plugin

Open krishagarwal278 opened this issue 5 months ago • 20 comments

krishagarwal278 avatar Aug 12 '25 20:08 krishagarwal278

@krishagarwal278: This pull request references CONSOLE-4677 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 12 '25 20:08 openshift-ci-robot

/label docs-approved /label px-approved

krishagarwal278 avatar Aug 12 '25 20:08 krishagarwal278

/label tide/merge-method-squash

krishagarwal278 avatar Aug 12 '25 20:08 krishagarwal278

/assign @yapei /assign @jhadvig

krishagarwal278 avatar Aug 12 '25 20:08 krishagarwal278

Checked on cluster launched against the pr. The regression test passed. /label qe-approved

yanpzhan avatar Aug 14 '25 07:08 yanpzhan

@krishagarwal278: This pull request references CONSOLE-4677 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 14 '25 07:08 openshift-ci-robot

/retest

krishagarwal278 avatar Aug 14 '25 17:08 krishagarwal278

The frontend test is failing with a few valid issues Screenshot 2025-08-15 at 14 04 00

jhadvig avatar Aug 15 '25 12:08 jhadvig

The frontend test is failing with a few valid issues Screenshot 2025-08-15 at 14 04 00

Yes, latest commit should address this failure

krishagarwal278 avatar Aug 15 '25 15:08 krishagarwal278

LGTM! Since I am not the React expert, I will leave this PR for others to take a second look.

Leo6Leo avatar Aug 27 '25 14:08 Leo6Leo

/label acknowledge-critical-fixes-only

krishagarwal278 avatar Aug 27 '25 18:08 krishagarwal278

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishagarwal278, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 27 '25 19:08 openshift-ci[bot]

/retest

krishagarwal278 avatar Aug 28 '25 14:08 krishagarwal278

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Aug 28 '25 15:08 openshift-ci[bot]

/retest

krishagarwal278 avatar Sep 03 '25 13:09 krishagarwal278

/retest

krishagarwal278 avatar Sep 03 '25 19:09 krishagarwal278

@krishagarwal278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 5c0a1aa70adf2861aad7d0fd29903697e4f76ab1 link true /test e2e-gcp-console
ci/prow/frontend 5c0a1aa70adf2861aad7d0fd29903697e4f76ab1 link true /test frontend

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 11 '25 23:09 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Dec 11 '25 09:12 openshift-bot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Dec 11 '25 09:12 openshift-merge-robot

[!IMPORTANT]

Review skipped

Auto reviews are limited based on label configuration.

:no_entry_sign: Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 11 '25 09:12 coderabbitai[bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Jan 11 '26 00:01 openshift-bot