openshift
OCPBUGS-44505: remove crypto-browserify library and use Crypto instead
This PR replaces the use of crypto-browserify for generating a hash for a given username with the native Crypto object and its subtle.digest method, which is supported in all browsers compatible with v4.21. This way we not only remove unnecessary dependencies, but also use browser-optimized native cryptographic functionality.
Changes in this PR:
- Replaced
crypto-browserify's createHash function with a newly implementedgenerateHashfunction that utilizes browser-nativeCrypto.subtle.digest. - Removed crypto-browserify from the dependencies as this was its sole usage in the codebase.
@Mylanos: This pull request references Jira Issue OCPBUGS-44505, which is invalid:
- expected the bug to target the "4.18.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Mylanos: This pull request references Jira Issue OCPBUGS-44505, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.18.0) matches configured target version for branch (4.18.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD 58e9c11c19ce915f20213d9ba9a54d2e05809baf and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD 687d0e8477d100fca98c5877bf9e7cc8a80d9260 and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total
/retest-required
Remaining retests: 0 against base HEAD 895d97902383514513224bbaf8a8df8f12c83bea and 1 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total