console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.14] OCPBUGS-36558: Increase login flow state paramater length/entropy

Open openshift-cherrypick-robot opened this issue 1 year ago • 4 comments

This is an automated cherry-pick of #14422

/assign TheRealJon

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-36559 with correct target version. Will retitle the PR to link to the clone. /retitle [release-4.14] OCPBUGS-36558: Increase login flow state paramater length/entropy

In response to this:

This is an automated cherry-pick of #14422

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 25 '24 11:10 openshift-ci-robot

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36558, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-36559 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #14422

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 25 '24 11:10 openshift-ci-robot

/retest-required

joepvd avatar Nov 06 '24 15:11 joepvd

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 06 '24 19:11 openshift-ci[bot]

Checked on cluster launched against the pr, accessed console url, checked "state" parameter in login redirect url, it's 16 bytes. /label qe-approved /label cherry-pick-approved

yanpzhan avatar Nov 08 '24 06:11 yanpzhan

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36558, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #14422

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 08 '24 06:11 openshift-ci-robot

/lgtm

jhadvig avatar Nov 08 '24 13:11 jhadvig

/jira refresh

jhadvig avatar Nov 08 '24 13:11 jhadvig

@jhadvig: This pull request references Jira Issue OCPBUGS-36558, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 08 '24 13:11 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 08 '24 13:11 openshift-ci[bot]

/jira refresh

jhadvig avatar Nov 12 '24 13:11 jhadvig

@jhadvig: This pull request references Jira Issue OCPBUGS-36558, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 12 '24 13:11 openshift-ci-robot

/jira refresh

jhadvig avatar Nov 12 '24 13:11 jhadvig

@jhadvig: This pull request references Jira Issue OCPBUGS-36558, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-36559 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-36559 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 12 '24 13:11 openshift-ci-robot

/cherry-pick release-4.13

jhadvig avatar Nov 12 '24 13:11 jhadvig

@jhadvig: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36558: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36558 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #14422

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 12 '24 13:11 openshift-ci-robot

@jhadvig: new pull request created: #14483

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.14.0-202411121405.p0.g1fcdea9.assembly.stream.el8. All builds following this will include this PR.

openshift-bot avatar Nov 12 '24 15:11 openshift-bot

Fix included in accepted release 4.14.0-0.nightly-2024-11-12-152934

openshift-merge-robot avatar Nov 12 '24 20:11 openshift-merge-robot