openshift
OCPBUGS-43717: Should not show Hide/Reveal values button for binary type secret data
Dont show button for revealing contents of Opaque/binary secret filetype uploaded as a secret data
@Mylanos: This pull request references Jira Issue OCPBUGS-43717, which is invalid:
- expected the bug to target the "4.18.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Dont show button for revealing contents of Opaque/binary secret filetype uploaded as a secret data
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Mylanos: This pull request references Jira Issue OCPBUGS-43717, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.18.0) matches configured target version for branch (4.18.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Mylanos: This pull request references Jira Issue OCPBUGS-43717, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.18.0) matches configured target version for branch (4.18.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
Dont show button for revealing contents of Opaque/binary secret filetype uploaded as a secret data.
Before:
https://github.com/user-attachments/assets/c4e372b0-7980-4b1b-8909-871527874de8
After:
https://github.com/user-attachments/assets/c9e4685d-3b28-479a-b1ba-2441c97d8861
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cyril-ui-developer, Mylanos
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [cyril-ui-developer]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Mylanos: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/okd-scos-e2e-aws-ovn | db3539e643edd38269231c8b29d108d7e6b6e344 | link | false | /test okd-scos-e2e-aws-ovn |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@Mylanos: Jira Issue OCPBUGS-43717: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-43717 has been moved to the MODIFIED state.
In response to this:
The issue was that we have previously shown the button for revealing contents of Opaque/binary secret filetype uploaded as a secret data. As a resolution I incorporated a state variable that represented presence of a non-binary data file uploaded in the secret -> meaning there is something to be shown/revealed. This state variable was used to conditionally show the button, that was previously shown all the time. As part of the fix I took an advantage and broke down the reveal button into its own component.
Before:
https://github.com/user-attachments/assets/7c294711-d498-4d54-ba9f-7b2b27a3c854
After ( binary files and combination ):
https://github.com/user-attachments/assets/c9e4685d-3b28-479a-b1ba-2441c97d8861
After ( no value secrets ):
https://github.com/user-attachments/assets/68b411da-164d-41cd-940c-5ff7e4f5d943
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[ART PR BUILD NOTIFIER]
Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.19.0-202411142010.p0.g2705900.assembly.stream.el9. All builds following this will include this PR.
