openshift
CONSOLE-4234,CONSOLE-4298: Remove PF deprecated table from public/components/factory/table.tsx
- Refactor public/components/factory/table.tsx to remove deprecated PF table
- Separate virtualized/non-virtualized tables into local sub-components
- Remove unused generic types
@TheRealJon: This pull request references CONSOLE-4234 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
This pull request references CONSOLE-4298 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
In response to this:
- Refactor public/components/factory/table.tsx to remove deprecated PF table
- Separate virtualized/non-virtualized tables into local sub-components
- Remove unused generic types
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
QE Approver /assign @yapei
Docs Approver: /assign @opayne1
PX Approver: /assign @reestr
Regression test about table against the pr code passed. /label qe-approved
@TheRealJon: This pull request references CONSOLE-4234 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
This pull request references CONSOLE-4298 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
In response to this:
- Refactor public/components/factory/table.tsx to remove deprecated PF table
- Separate virtualized/non-virtualized tables into local sub-components
- Remove unused generic types
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@TheRealJon: This pull request references CONSOLE-4234 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
This pull request references CONSOLE-4298 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
This pull request references CONSOLE-4299 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
In response to this:
- Refactor public/components/factory/table.tsx to remove deprecated PF table
- Separate virtualized/non-virtualized tables into local sub-components
- Remove unused generic types
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@TheRealJon: This pull request references CONSOLE-4234 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
This pull request references CONSOLE-4298 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
This pull request references CONSOLE-4299 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
In response to this:
public/components/factory/table.tsx
- Refactor Table component to remove PatternFly deprecated Table component
- Separate virtualized/non-virtualized tables into local sub-components
- Remove unused generic types
public/components/factory/Table/VirtualizedTable.tsx
- Refactor VirtualizedTable component to remove PatternFly deprecated Table component
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@TheRealJon: This pull request references CONSOLE-4234 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
This pull request references CONSOLE-4298 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
This pull request references CONSOLE-4299 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
In response to this:
public/components/factory/table.tsx
- Refactor Table component to remove PatternFly deprecated Table component
- Separate virtualized/non-virtualized tables into local sub-components
- Remove unused generic types
- Address some nits and tech debt
public/components/factory/Table/VirtualizedTable.tsx
- Refactor VirtualizedTable component to remove PatternFly deprecated Table component
- Address a few nits and tech debt
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD ea76ee699113d251e74be989e6ca9613e717db33 and 2 for PR HEAD eebeb8ecc316b0c36073430084711a2095e7f5b1 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 1 for PR HEAD eebeb8ecc316b0c36073430084711a2095e7f5b1 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD eebeb8ecc316b0c36073430084711a2095e7f5b1 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD eebeb8ecc316b0c36073430084711a2095e7f5b1 in total
/retest-required
Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD a9fa2ed6ca63ad1ab022e40246074a0f951d6137 in total
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: logonoff, rhamilto, TheRealJon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [TheRealJon,rhamilto]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@TheRealJon: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.19.0-202411300443.p0.g895d979.assembly.stream.el9. All builds following this will include this PR.
