console icon indicating copy to clipboard operation
console copied to clipboard

ODC-7698: Replace `CopyPipelineRunButton` with PF5 design

Open logonoff opened this issue 4 months ago • 9 comments

Fixes:

https://issues.redhat.com/browse/ODC-7698

Solution Description:

Remove react-copy-to-clipboard dep, remove CopyPipelineRunButton, and switch from a monaco-based design to the PatternFly-provided multiline design

I considered other options, such as rewriting the CopyPipelineRunButton using the PatternFly component; however, the presence of the textId prop in PF's ClipboardCopyButton highly implies that the intended design should accompany a node in the DOM with an id containing the text to be copied. However, the EditorField does not have an ID containing just the text, and copying from its parent would include line numbers.

Screen shots / Gifs for design review:

demo

https://github.com/user-attachments/assets/881f641c-6222-486b-a948-e13be739c9a3

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

logonoff avatar Oct 17 '24 16:10 logonoff