openshift
CONSOLE-4125,CONSOLE-4294: Replace SelectDeprecated component in user preferences PerspectiveDropdown
- Rename PerspectiveDropdown to PreferredPerspectiveSelect
- Refactor PreferredPerspectiveSelect to use supported PF Select component
- Update unit tests to use RTL
@TheRealJon: This pull request references CONSOLE-4125 which is a valid jira issue.
This pull request references CONSOLE-4294 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
In response to this:
- Rename PerspectiveDropdown to PreferredPerspectiveSelect
- Refactor PreferredPerspectiveSelect to use supported PF Select component
- Update unit tests to use RTL
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
QE Approver /assign @yapei
Docs Approver: /assign @opayne1
PX Approver: /assign @reestr
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rhamilto, TheRealJon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [TheRealJon,rhamilto]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Launched cluster against the pr. Regression test to Perspective Dropdown field on user preference page passed. /label qe-approved
@TheRealJon: This pull request references CONSOLE-4125 which is a valid jira issue.
This pull request references CONSOLE-4294 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.
In response to this:
- Rename PerspectiveDropdown to PreferredPerspectiveSelect
- Refactor PreferredPerspectiveSelect to use supported PF Select component
- Update unit tests to use RTL
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@opayne1 Perspective switcher is still the correct terminology. This PR effects a different interaction than the main perspective switcher.
@reestr Anything I can do to help expedite? I think this is ready to merge once you approve.
@TheRealJon: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411111538.p0.g8eba125.assembly.stream.el9. All builds following this will include this PR.
