console icon indicating copy to clipboard operation
console copied to clipboard

CONSOLE-4287: Restore kubevirt extensions for the topology plugin

Open pcbailey opened this issue 1 year ago • 14 comments

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/CONSOLE-4287

Screenshots

Before

restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33

After

restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04

pcbailey avatar Oct 02 '24 01:10 pcbailey

@pcbailey: This pull request references CNV-45158 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/CNV-45158

Screenshots

Before

restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33

After

restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 02 '24 01:10 openshift-ci-robot

@pcbailey: This pull request references CNV-45158 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/OCPBUGS-42672

Screenshots

Before

restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33

After

restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 02 '24 02:10 openshift-ci-robot

@pcbailey: This pull request references Jira Issue OCPBUGS-42672, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/OCPBUGS-42672

Screenshots

Before

restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33

After

restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 02 '24 02:10 openshift-ci-robot

/jira refresh

upalatucci avatar Oct 02 '24 11:10 upalatucci

@upalatucci: This pull request references Jira Issue OCPBUGS-42672, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 02 '24 11:10 openshift-ci-robot

/jira refresh

pcbailey avatar Oct 02 '24 14:10 pcbailey

@pcbailey: This pull request references Jira Issue OCPBUGS-42672, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 02 '24 14:10 openshift-ci-robot

/lgtm

upalatucci avatar Oct 03 '24 12:10 upalatucci

/approve

upalatucci avatar Oct 03 '24 12:10 upalatucci

@pcbailey: This pull request references Jira Issue OCPBUGS-42672, which is invalid:

  • expected the story to target the "4.18.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Code Review instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/CONSOLE-4287

Screenshots

Before

restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33

After

restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 03 '24 20:10 openshift-ci-robot

@pcbailey: This pull request references CONSOLE-4287 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/CONSOLE-4287

Screenshots

Before

restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33

After

restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 03 '24 20:10 openshift-ci-robot

Docs Approver: /assign @opayne1 PX Approver: /assign @reestr QA Approver: /assign @yapei

jhadvig avatar Nov 06 '24 16:11 jhadvig

VirtualMachines can be shown in topology view but I'm consistently seeing Uncaught runtime errors when navigating through virtualization pages, here is one recording I'm running following bridge commands locally

./bin/bridge -plugins kubevirt-plugin=http://localhost:9001 -i18n-namespaces=plugin__kubevirt-plugin

https://github.com/user-attachments/assets/6dbcf3e4-6604-4ad8-98f6-8e5c103119ab

yapei avatar Nov 07 '24 08:11 yapei

@yapei i think this pr is not correlated to the error. We are experiencing the issue even on console latest

upalatucci avatar Nov 13 '24 08:11 upalatucci

Thanks @upalatucci You are right, I tried on latest console master and see the same error Regarding this PR changes, everything looks good so far Screenshot 2024-11-14 at 10 12 47 AM /label qe-approved

yapei avatar Nov 14 '24 02:11 yapei

@pcbailey: This pull request references CONSOLE-4287 which is a valid jira issue.

In response to this:

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/CONSOLE-4287

Screenshots

Before

restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33

After

restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 14 '24 02:11 openshift-ci-robot

/lgtm

upalatucci avatar Nov 25 '24 14:11 upalatucci

/retest

pcbailey avatar Nov 25 '24 16:11 pcbailey

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Nov 26 '24 12:11 openshift-ci[bot]

/retest

pcbailey avatar Nov 26 '24 14:11 pcbailey

/retest

pcbailey avatar Nov 26 '24 20:11 pcbailey

/retest

pcbailey avatar Nov 27 '24 20:11 pcbailey

/retest

pcbailey avatar Dec 03 '24 13:12 pcbailey

/retest

pcbailey avatar Dec 03 '24 23:12 pcbailey

/retest

pcbailey avatar Dec 05 '24 11:12 pcbailey

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pcbailey, upalatucci Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Dec 12 '24 14:12 openshift-ci[bot]

@pcbailey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend 9ab19c4a2fbe9cf38cbb17c288ded4f1e94e2e02 link true /test frontend
ci/prow/okd-scos-images 9ab19c4a2fbe9cf38cbb17c288ded4f1e94e2e02 link true /test okd-scos-images
ci/prow/e2e-gcp-console 9ab19c4a2fbe9cf38cbb17c288ded4f1e94e2e02 link true /test e2e-gcp-console
ci/prow/backend 9ab19c4a2fbe9cf38cbb17c288ded4f1e94e2e02 link true /test backend
ci/prow/images 9ab19c4a2fbe9cf38cbb17c288ded4f1e94e2e02 link true /test images
ci/prow/analyze 9ab19c4a2fbe9cf38cbb17c288ded4f1e94e2e02 link true /test analyze

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Feb 18 '25 00:02 openshift-ci[bot]

These changes are being added to the dynamic kubevirt-plugin.

pcbailey avatar Apr 28 '25 12:04 pcbailey