console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-32033: Fix Function Import: An error occurred Cannot read properties of undefined (reading 'filter')

Open vikram-raj opened this issue 1 year ago • 6 comments

Fixes: https://issues.redhat.com/browse/OCPBUGS-32033

Descriptions: When users import a Serverless func repo and build.buildEnvs or run.envs is not defined in the func.yaml then UI throw an error on creation. This PR adds [] if envs is not defined.

vikram-raj avatar Aug 12 '24 15:08 vikram-raj

@vikram-raj: This pull request references Jira Issue OCPBUGS-32033, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-32033

Descriptions: When users import a Serverless func repo and build.buildEnvs or run.envs is not defined in the func.yaml then UI throw an error on creation. This PR adds [] if envs is not defined.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 12 '24 15:08 openshift-ci-robot

Hi @vikram-raj ,

I am not getting the error in Git import flow of serverless but I am still getting error in normal import flow.

lokanandaprabhu avatar Aug 13 '24 05:08 lokanandaprabhu

/assign @vikram-raj

christoph-jerolimov avatar Sep 21 '24 07:09 christoph-jerolimov

Would it be possible to merge / fix this issue?

pierDipi avatar Oct 25 '24 08:10 pierDipi

/jira refresh

vikram-raj avatar Nov 28 '24 14:11 vikram-raj

@vikram-raj: This pull request references Jira Issue OCPBUGS-32033, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 28 '24 14:11 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 29 '24 06:11 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 99d0e2be2d4d1e34b48766d15f8f75d3952c8bda and 2 for PR HEAD 7ef33df76a7c50c5e812fac6a0b41475edeb6b84 in total

openshift-ci-robot avatar Nov 29 '24 06:11 openshift-ci-robot

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 29 '24 11:11 openshift-ci[bot]

@vikram-raj: Jira Issue OCPBUGS-32033: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32033 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-32033

Descriptions: When users import a Serverless func repo and build.buildEnvs or run.envs is not defined in the func.yaml then UI throw an error on creation. This PR adds [] if envs is not defined.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 29 '24 19:11 openshift-ci-robot

/cherrypick release-4.18

lokanandaprabhu avatar Dec 02 '24 04:12 lokanandaprabhu

@lokanandaprabhu: new pull request created: #14559

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.