console icon indicating copy to clipboard operation
console copied to clipboard

add IBM Block Storage CSI driver support for RWX

Open kasserater opened this issue 1 year ago • 7 comments

the upcoming IBM Block Storage CSI driver support release will add support for RWX adding now so that we can start Beta testing with customers

kasserater avatar Jul 21 '24 06:07 kasserater

Hi @kasserater. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jul 21 '24 06:07 openshift-ci[bot]

/cc @kyoto

kasserater avatar Jul 21 '24 06:07 kasserater

@kyoto can you be so kind and review this change? we have multiple customers wanting to Beta test our new IBM Block Storage CSI driver with RWX support, specifically with regards to VM virtualization and live-migration. This will have a big impact on RH and IBM sales.

kasserater avatar Jul 21 '24 06:07 kasserater

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Oct 19 '24 09:10 openshift-bot

/remove-lifecycle stale

csiblock avatar Oct 21 '24 04:10 csiblock

/assign @kyoto

csiblock avatar Oct 21 '24 04:10 csiblock

@TheRealJon @jhadvig can you please assist with the review of this PR?

csiblock avatar Nov 06 '24 18:11 csiblock

/assign @TheRealJon

csiblock avatar Nov 18 '24 01:11 csiblock

/assign @jhadvig

csiblock avatar Nov 18 '24 01:11 csiblock

/assign @vojtechszocs

all - please note that we have passed our Beta phase and we are planning on releasing the upcoming IBM CSI 1.12.0 release in the next several weeks. We would really appreciate the review and approval here, so that upcoming OpenShift releases will allow customers set RWX access modes

csiblock avatar Nov 18 '24 01:11 csiblock

/assign @lokanandaprabhu /assign @logonoff /assign @cyril-ui-developer /assign @vikram-raj /assign @christoph-jerolimov /assign @upalatucci /assign @Lucifergene /assign @rhamilto /assign @pcbailey

csiblock avatar Nov 18 '24 01:11 csiblock

@csiblock: GitHub didn't allow me to assign the following users: upalatucci, rhamilto, vikram-raj.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @lokanandaprabhu /assign @logonoff /assign @cyril-ui-developer /assign @vikram-raj /assign @christoph-jerolimov /assign @upalatucci /assign @Lucifergene /assign @rhamilto /assign @pcbailey

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Nov 18 '24 01:11 openshift-ci[bot]

/ok-to-test

logonoff avatar Nov 18 '24 02:11 logonoff

/assign @vojtechszocs

all - please note that we have passed our Beta phase and we are planning on releasing the upcoming IBM CSI 1.12.0 release in the next several weeks. We would really appreciate the review and approval here, so that upcoming OpenShift releases will allow customers set RWX access modes

Could you open a CONSOLE jira ticket? Since PRs can't be merged without jira/valid-reference

logonoff avatar Nov 18 '24 02:11 logonoff

@logonoff I lack sufficient permissions to create a CONSOLE Jira ticket (i can find the project in the projects directory, but cannot select it for ticket creation). @csiblock cannot even find the CONSOLE Jira project in the projects directory how can we gain access to the project as well as permissions to create tickets? i would like to add those permissions to the rest of my development team as well

  • @eranrotker
  • @shlomitn
  • @uriziv1
  • @shirlyfa
  • @chengoldi
  • @eyalbeIL
  • @ilanoxen
  • @kariyb
  • @lechapitre

kasserater avatar Nov 18 '24 07:11 kasserater

/retitle CONSOLE-4356: Add IBM Block Storage CSI driver support for RWX

logonoff avatar Nov 18 '24 12:11 logonoff

@kasserater: This pull request references CONSOLE-4356 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

the upcoming IBM Block Storage CSI driver support release will add support for RWX adding now so that we can start Beta testing with customers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 18 '24 12:11 openshift-ci-robot

thank you @logonoff for opening the Jira ticket for me and linking it to this PR our upcoming CSI release will support OCP 4.14 through 4.17, so that should be set as the target fix version in Jira (if you Jira project scheme allows for multiple fix versions)

what are the next required steps to complete this PR?

kasserater avatar Nov 18 '24 12:11 kasserater

/retitle OCPBUGS-44657: Add IBM Block Storage CSI driver support for RWX

logonoff avatar Nov 18 '24 14:11 logonoff

@kasserater: This pull request references Jira Issue OCPBUGS-44657, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

the upcoming IBM Block Storage CSI driver support release will add support for RWX adding now so that we can start Beta testing with customers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 18 '24 14:11 openshift-ci-robot

thank you @logonoff for opening the Jira ticket for me and linking it to this PR our upcoming CSI release will support OCP 4.14 through 4.17, so that should be set as the target fix version in Jira (if you Jira project scheme allows for multiple fix versions)

what are the next required steps to complete this PR?

Someone from the console team will look at the PR and may provide comments. Until then no further action is required

logonoff avatar Nov 18 '24 14:11 logonoff

/jira refresh

logonoff avatar Nov 18 '24 14:11 logonoff

@logonoff: This pull request references Jira Issue OCPBUGS-44657, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 18 '24 14:11 openshift-ci-robot

  • Create a demo storageclass whose provisioner is provisioner: block.csi.ibm.com
  • Goes to PVC creation page, check Access mode list, we can see RWO(ReadWriteOnce) and RWX(ReadWriteMany) Screenshot 2024-11-19 at 2 07 34 PM

yapei avatar Nov 19 '24 06:11 yapei

/label qe-approved

yapei avatar Nov 19 '24 06:11 yapei

@kasserater: This pull request references Jira Issue OCPBUGS-44657, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

the upcoming IBM Block Storage CSI driver support release will add support for RWX adding now so that we can start Beta testing with customers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 19 '24 06:11 openshift-ci-robot

/lgtm

cajieh avatar Nov 19 '24 14:11 cajieh

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csiblock, cyril-ui-developer, kasserater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 19 '24 14:11 openshift-ci[bot]

/unassign christoph-jerolimov /unassign kyoto /unassign vojtechszocs /unassign jhadvig /unassign pcbailey /unassign logonoff /unassign TheRealJon /unassign Lucifergene /unassign lokanandaprabhu

logonoff avatar Nov 19 '24 14:11 logonoff

/retest-required

Remaining retests: 0 against base HEAD 9d35cf2370f8594e23a7300a906cdea24a6b76ba and 2 for PR HEAD d66d5cef10510d49c4969aba1abe8c9c510f4be8 in total

openshift-ci-robot avatar Nov 19 '24 15:11 openshift-ci-robot