console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-36619: Switch to use annotations as labels from PipelineRuns created through Pipelines as Code is deprecated

Open vikram-raj opened this issue 1 year ago • 4 comments

Fixes: https://issues.redhat.com/browse/OCPBUGS-36619

Descriptions: The labels added by PAC have been deprecated and added to PLR annotations. So, use annotations to get the value in the repository list page, repository PLRs list page, and on the PLR details page.

Test steps:

  • Check Repository list page
  • PipelineRuns list page for repository
  • PipelineRun details page
  • Repository details page

vikram-raj avatar Jul 05 '24 11:07 vikram-raj

@vikram-raj: This pull request references Jira Issue OCPBUGS-36619, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-36619

Descriptions: The labels added by PAC have been deprecated and added to PLR annotations. So, use annotations to get the value in the repository list page, repository PLRs list page, and on the PLR details page.

Test steps:

  • Check Repository list page
  • PipelineRuns list page for repository
  • PipelineRun details page
  • Repository details page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 05 '24 11:07 openshift-ci-robot

/cc @lokanandaprabhu

vikram-raj avatar Jul 05 '24 11:07 vikram-raj

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 29 '24 16:07 openshift-ci[bot]

Tested locally. Able to load PLR list page in repository details page.

/lgtm

Screenshot 2024-07-30 at 11 01 48 AM

lokanandaprabhu avatar Jul 30 '24 05:07 lokanandaprabhu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 30 '24 05:07 openshift-ci[bot]

@vikram-raj: Jira Issue OCPBUGS-36619: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36619 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-36619

Descriptions: The labels added by PAC have been deprecated and added to PLR annotations. So, use annotations to get the value in the repository list page, repository PLRs list page, and on the PLR details page.

Test steps:

  • Check Repository list page
  • PipelineRuns list page for repository
  • PipelineRun details page
  • Repository details page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 30 '24 05:07 openshift-ci-robot

/cherry-pick release-4.16

vikram-raj avatar Jul 30 '24 05:07 vikram-raj

@vikram-raj: new pull request created: #14094

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202407300742.p0.ga19cfb7.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Jul 30 '24 08:07 openshift-bot