openshift
OU-251: Remove alerts list from console codebase
This PR is apart of a pair of PR's (along with this one in the monitoring-plugin) which look to move the alerting list page from the console codebase over to the monitorin-plugin. This PR needs to wait for the other PR in the monitoring-plugin codebase to merge before it can merge. So long as the other PR merges first, then in the case of a desync of releases there would be 2 alerting tabs which both link to the current developer perspective table. I would further prefer if both could be merged at the same time, by receiving approval on both before either merges.
This set of PR's change the UI of the developer perspective to be consistent with the admin perspective. The overall functionality stays the same, but there are some changes to the workflows required. For example to silence the alert you can't do so directly from the table anymore, instead you will click the ellipsis and then select the "Silence alert" option.
In addition, the tab control is currently done manually in the console codebase, with new additions being added at the end. A future will add a console.action/group as well as some logic to dictate the tab ordering inside the console codebase
@PeterYurkovich: This pull request references OU-251 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.
In response to this:
This PR is apart of a pair of PR's (along with this one in the monitoring-plugin) which look to move the alerting list page from the console codebase over to the monitoring one. This PR needs to wait for the other PR in the monitoring-plugin codebase to merge before it can merge. I would further prefer if both could be merged at the same time, by receiving approval on both before either merges.
This set of PR's change the UI of the developer perspective to be consistent with the admin perspective. The overall functionality stays the same, but there are some changes to the workflows required. For example to silence the alert you can't do so directly from the table anymore, instead you will click the ellipsis and then select the "Silence alert" option.
In addition, the tab control is done manually in the console block, with new additions being added at the end. So until the rest of the monitoring tabs are moved over the tabs will be out of their typical order as seen in the image above.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@PeterYurkovich: This pull request references OU-251 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.
In response to this:
This PR is apart of a pair of PR's (along with this one in the monitoring-plugin) which look to move the alerting list page from the console codebase over to the monitoring one. This PR needs to wait for the other PR in the monitoring-plugin codebase to merge before it can merge. I would further prefer if both could be merged at the same time, by receiving approval on both before either merges.
This set of PR's change the UI of the developer perspective to be consistent with the admin perspective. The overall functionality stays the same, but there are some changes to the workflows required. For example to silence the alert you can't do so directly from the table anymore, instead you will click the ellipsis and then select the "Silence alert" option.
In addition, the tab control is done manually in the console codebase, with new additions being added at the end. So until the rest of the monitoring tabs are moved over the tabs will be out of their typical order as seen in the image above.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@PeterYurkovich: This pull request references OU-251 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.17." or "openshift-4.17.", but it targets "OpenShift 4.17" instead.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@PeterYurkovich: This pull request references OU-251 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.17." or "openshift-4.17.", but it targets "OpenShift 4.17" instead.
In response to this:
This PR is apart of a pair of PR's (along with this one in the monitoring-plugin) which look to move the alerting list page from the console codebase over to the monitoring one. This PR needs to wait for the other PR in the monitoring-plugin codebase to merge before it can merge. So long as the other PR merges first, then in the case of a desync of releases there would be 2 alerting tabs which both link to the current developer perspective table. I would further prefer if both could be merged at the same time, by receiving approval on both before either merges.
This set of PR's change the UI of the developer perspective to be consistent with the admin perspective. The overall functionality stays the same, but there are some changes to the workflows required. For example to silence the alert you can't do so directly from the table anymore, instead you will click the ellipsis and then select the "Silence alert" option.
In addition, the tab control is done manually in the console codebase, with new additions being added at the end. So until the rest of the monitoring tabs are moved over the tabs will be out of their typical order as seen in the image above.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@PeterYurkovich: This pull request references OU-251 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.17." or "openshift-4.17.", but it targets "OpenShift 4.17" instead.
In response to this:
This PR is apart of a pair of PR's (along with this one in the monitoring-plugin) which look to move the alerting list page from the console codebase over to the monitorin-plugin. This PR needs to wait for the other PR in the monitoring-plugin codebase to merge before it can merge. So long as the other PR merges first, then in the case of a desync of releases there would be 2 alerting tabs which both link to the current developer perspective table. I would further prefer if both could be merged at the same time, by receiving approval on both before either merges.
This set of PR's change the UI of the developer perspective to be consistent with the admin perspective. The overall functionality stays the same, but there are some changes to the workflows required. For example to silence the alert you can't do so directly from the table anymore, instead you will click the ellipsis and then select the "Silence alert" option.
In addition, the tab control is done manually in the console codebase, with new additions being added at the end. So until the rest of the monitoring tabs are moved over the tabs will be out of their typical order as seen in the image above.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@PeterYurkovich: This pull request references OU-251 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.17." or "openshift-4.17.", but it targets "OpenShift 4.17" instead.
In response to this:
This PR is apart of a pair of PR's (along with this one in the monitoring-plugin) which look to move the alerting list page from the console codebase over to the monitorin-plugin. This PR needs to wait for the other PR in the monitoring-plugin codebase to merge before it can merge. So long as the other PR merges first, then in the case of a desync of releases there would be 2 alerting tabs which both link to the current developer perspective table. I would further prefer if both could be merged at the same time, by receiving approval on both before either merges.
This set of PR's change the UI of the developer perspective to be consistent with the admin perspective. The overall functionality stays the same, but there are some changes to the workflows required. For example to silence the alert you can't do so directly from the table anymore, instead you will click the ellipsis and then select the "Silence alert" option.
In addition, the tab control is currently done manually in the console codebase, with new additions being added at the end. A future will add a
console.action/groupas well as some logic to dictate the tab ordering inside the console codebase
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@PeterYurkovich: This pull request references OU-251 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.17." or "openshift-4.17.", but it targets "OpenShift 4.17" instead.
In response to this:
This PR is apart of a pair of PR's (along with this one in the monitoring-plugin) which look to move the alerting list page from the console codebase over to the monitorin-plugin. This PR needs to wait for the other PR in the monitoring-plugin codebase to merge before it can merge. So long as the other PR merges first, then in the case of a desync of releases there would be 2 alerting tabs which both link to the current developer perspective table.
This set of PR's change the UI of the developer perspective to be consistent with the admin perspective. The overall functionality stays the same, but there are some changes to the workflows required. For example to silence the alert you can't do so directly from the table anymore, instead you will click the ellipsis and then select the "Silence alert" option.
In addition, the tab control is currently done manually in the console codebase, with new additions being added at the end. A future will add a
console.action/groupas well as some logic to dictate the tab ordering inside the console codebase
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@PeterYurkovich: This pull request references OU-251 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.17." or "openshift-4.17.", but it targets "OpenShift 4.17" instead.
In response to this:
This PR is apart of a pair of PR's (along with this one in the monitoring-plugin) which look to move the alerting list page from the console codebase over to the monitorin-plugin. This PR needs to wait for the other PR in the monitoring-plugin codebase to merge before it can merge. So long as the other PR merges first, then in the case of a desync of releases there would be 2 alerting tabs which both link to the current developer perspective table.
This set of PR's change the UI of the developer perspective to be consistent with the admin perspective. The overall functionality stays the same, but there are some changes to the workflows required. For example to silence the alert you can't do so directly from the table anymore, instead you will click the ellipsis and then select the "Silence alert" option.
In addition, the tab control is currently done manually in the console codebase, with new additions being added at the end. A future PR will add a
console.action/groupas well as some logic to dictate the tab ordering inside the console codebase
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
https://github.com/openshift/monitoring-plugin/pull/125 is merged /hold cancel
Approval: /assign @vikram-raj Docs Approver: /assign @opayne1 PX Approver: /assign @RickJWagner
The monitoring-plugin was adding the rules labels onto the alerts labels, so when the alert labels got encoded into the url there were additional labels, causing the alerts detail page to fail to match.
I've prevented the rules labels from being added onto the alerts in the developer perspective in a separate for the monitoring-plugin PR and will update this one once that has merged
The monitoring-plugin PR has been merged and the No Alert found issue has been fixed with it
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jgbernalp, PeterYurkovich, vikram-raj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/dev-console/OWNERS~~ [vikram-raj]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@PeterYurkovich you need to create and link CONSOLE or ODC jira ticket to get it merged.
Based on the tide results I believe this PR is waiting on the qe-approved tag from @juzhao once they finish their testing. Is there another reason, such as tracking, that another ticket would be needed?
@vikram-raj it seems we already have the jira/valid-reference. Do we still need to create a jira ticket on those projects?
@PeterYurkovich: This pull request references OU-251 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.17." or "openshift-4.17.", but it targets "OpenShift 4.17" instead.
In response to this:
This PR is apart of a pair of PR's (along with this one in the monitoring-plugin) which look to move the alerting list page from the console codebase over to the monitorin-plugin. This PR needs to wait for the other PR in the monitoring-plugin codebase to merge before it can merge. So long as the other PR merges first, then in the case of a desync of releases there would be 2 alerting tabs which both link to the current developer perspective table.
This set of PR's change the UI of the developer perspective to be consistent with the admin perspective. The overall functionality stays the same, but there are some changes to the workflows required. For example to silence the alert you can't do so directly from the table anymore, instead you will click the ellipsis and then select the "Silence alert" option.
In addition, the tab control is currently done manually in the console codebase, with new additions being added at the end. A future PR will add a
console.action/groupas well as some logic to dictate the tab ordering inside the console codebase
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jgbernalp: This pull request references OU-251 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.17." or "openshift-4.17.", but it targets "OpenShift 4.17" instead.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.