console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-35926: Add debounce to PAC auto selecton in git import flow

Open logonoff opened this issue 1 year ago • 9 comments

Fixes:

https://issues.redhat.com/browse/OCPBUGS-35926

Analysis / Root cause:

Debounce was not called when checking for .tekton file in import flow

Solution Description:

Debounce the function call

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

logonoff avatar Jun 27 '24 15:06 logonoff

@logonoff: This pull request references Jira Issue OCPBUGS-35926, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-35926

Analysis / Root cause:

Debounce was not called when checking for .tekton file in import flow

Solution Description:

Debounce the function call

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 27 '24 15:06 openshift-ci-robot

/jira refresh

logonoff avatar Jun 27 '24 16:06 logonoff

@logonoff: This pull request references Jira Issue OCPBUGS-35926, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 27 '24 16:06 openshift-ci-robot

/hold

logonoff avatar Jul 04 '24 19:07 logonoff

/unhold

logonoff avatar Jul 04 '24 19:07 logonoff

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, Lucifergene, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 05 '24 12:07 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD d5e3177e2daf13a66919c3e51776e03553324baf and 2 for PR HEAD 2dfb6fe3a342fa97250e3afdceb8f35564f786e0 in total

openshift-ci-robot avatar Jul 05 '24 13:07 openshift-ci-robot

/retest

logonoff avatar Jul 05 '24 15:07 logonoff

/retest

logonoff avatar Jul 05 '24 19:07 logonoff

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 05 '24 22:07 openshift-ci[bot]

@logonoff: Jira Issue OCPBUGS-35926: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35926 has been moved to the MODIFIED state.

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-35926

Analysis / Root cause:

Debounce was not called when checking for .tekton file in import flow

Solution Description:

Debounce the function call

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 05 '24 22:07 openshift-ci-robot

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202407052343.p0.g36ad377.assembly.stream.el9 for distgit openshift-enterprise-console. All builds following this will include this PR.

openshift-bot avatar Jul 06 '24 00:07 openshift-bot