openshift
OCPBUGS-31901: Patch PF dynamic module parser to exclude 'next' modules
This PR patches Console PF dynamic module parser for parity with patternfly/patternfly-react/pull/10046
- Ignore dynamic modules nested under
deprecatedornextdirectories - Add
@patternfly/react-tableto the list of packages to scan for dynamic modules by default inConsoleRemotePlugin
Once Console bumps PF packages to recent 5.3.x versions (#13770) we will update our dynamic module parser to try using dist/dynamic-modules.json files provided by these PF packages.
@vojtechszocs: This pull request references Jira Issue OCPBUGS-31901, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
This PR patches Console PF dynamic module parser for parity with patternfly/patternfly-react/pull/10046
- Ignore dynamic modules nested under
deprecatedornextdirectories- Add
@patternfly/react-tableto the list of packages to scan for dynamic modules by default inConsoleRemotePluginOnce Console bumps PF packages to recent 5.3.x versions (#13770) we will update our dynamic module parser to try using
dist/dynamic-modules.jsonfiles provided by these PF packages.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: TheRealJon, vojtechszocs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/console-dynamic-plugin-sdk/OWNERS~~ [TheRealJon,vojtechszocs]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jhadvig: This pull request references Jira Issue OCPBUGS-31901, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @zhouying7780
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@vojtechszocs: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@vojtechszocs: Jira Issue OCPBUGS-31901: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-31901 has been moved to the MODIFIED state.
In response to this:
This PR patches Console PF dynamic module parser for parity with patternfly/patternfly-react/pull/10046
- Ignore dynamic modules nested under
deprecatedornextdirectories- Add
@patternfly/react-tableto the list of packages to scan for dynamic modules by default inConsoleRemotePluginOnce Console bumps PF packages to recent 5.3.x versions (#13770) we will update our dynamic module parser to try using
dist/dynamic-modules.jsonfiles provided by these PF packages.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[ART PR BUILD NOTIFIER]
This PR has been included in build openshift-enterprise-console-container-v4.17.0-202405140243.p0.gbfee4c6.assembly.stream.el9 for distgit openshift-enterprise-console. All builds following this will include this PR.
@vojtechszocs: new pull request created: #13849
In response to this:
/cherry-pick release-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
