console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-29777: RWOP accessMode is not available on OpenShift console UI

Open cajieh opened this issue 1 year ago • 13 comments

Before:

Screenshot 2024-05-08 at 4 14 06 PM

After:

Screenshot 2024-05-08 at 4 20 11 PM

Screencast on how to validate the change

https://github.com/openshift/console/assets/15249132/eb0e26c8-e4b4-4611-8999-a9a501e07b75

cajieh avatar May 08 '24 20:05 cajieh

@cyril-ui-developer: No Jira issue with key WOCPBUGS-29777 exists in the tracker at https://issues.redhat.com/. Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 08 '24 20:05 openshift-ci-robot

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-29777, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 08 '24 20:05 openshift-ci-robot

/jira refresh

cajieh avatar May 08 '24 20:05 cajieh

/retest

cajieh avatar May 09 '24 00:05 cajieh

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-29777, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Before:

Screenshot 2024-05-08 at 4 14 06 PM

After:

Screenshot 2024-05-08 at 4 20 11 PM

Screencast on how to validate the change

https://github.com/openshift/console/assets/15249132/eb0e26c8-e4b4-4611-8999-a9a501e07b75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 09 '24 14:05 openshift-ci-robot

@yuvalgalanti shall we keep using radio buttons here or lets switch to dropdown ?

jhadvig avatar May 09 '24 14:05 jhadvig

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-29777. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Before:

Screenshot 2024-05-08 at 4 14 06 PM

After:

Screenshot 2024-05-08 at 4 20 11 PM

Screencast on how to validate the change

https://github.com/openshift/console/assets/15249132/eb0e26c8-e4b4-4611-8999-a9a501e07b75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 09 '24 14:05 openshift-ci-robot

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-29777, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Before:

Screenshot 2024-05-08 at 4 14 06 PM

After:

Screenshot 2024-05-08 at 4 20 11 PM

Screencast on how to validate the change

https://github.com/openshift/console/assets/15249132/eb0e26c8-e4b4-4611-8999-a9a501e07b75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 09 '24 14:05 openshift-ci-robot

/retest

cajieh avatar May 09 '24 16:05 cajieh

/assign @jhadvig @bipuladh PTAL, thanks.

cajieh avatar May 09 '24 16:05 cajieh

/retest

cajieh avatar May 10 '24 02:05 cajieh

@yuvalgalanti shall we keep using radio buttons here or let's switch to dropdown? I see what you are saying, since we have 4 options now I think having the access mode selection as a single select dropdown menu makes more sense and aligns with the convention in the OCP console.

yuvalgalanti avatar May 12 '24 07:05 yuvalgalanti

/retest

cajieh avatar May 20 '24 14:05 cajieh

/retest

cajieh avatar May 23 '24 23:05 cajieh

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-29777, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Before:

Screenshot 2024-05-08 at 4 14 06 PM

After:

Screenshot 2024-05-28 at 12 46 20 PM Screenshot 2024-05-28 at 12 49 46 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 28 '24 16:05 openshift-ci-robot

/retest

cajieh avatar May 28 '24 20:05 cajieh

/retest

cajieh avatar May 28 '24 22:05 cajieh

/retest

cajieh avatar May 31 '24 19:05 cajieh

/retest

cajieh avatar Jun 03 '24 02:06 cajieh

/retest

cajieh avatar Jun 03 '24 15:06 cajieh

/retest

cajieh avatar Jun 03 '24 19:06 cajieh

/retest

cajieh avatar Jun 04 '24 19:06 cajieh

/retest

cajieh avatar Jun 05 '24 12:06 cajieh

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 05 '24 17:06 openshift-ci[bot]

/jira refresh

cajieh avatar Jun 06 '24 14:06 cajieh

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-29777, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 06 '24 14:06 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, cyril-ui-developer, jhadvig, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 07 '24 12:06 openshift-ci[bot]

@cyril-ui-developer: Jira Issue OCPBUGS-29777: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29777 has been moved to the MODIFIED state.

In response to this:

Before:

Screenshot 2024-05-08 at 4 14 06 PM

After:

Screenshot 2024-05-31 at 9 21 11 AM Screenshot 2024-05-31 at 5 53 23 AM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 07 '24 18:06 openshift-ci-robot

/cherry-pick release-4.16

cajieh avatar Jul 09 '24 13:07 cajieh

@cyril-ui-developer: new pull request created: #14040

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.