console
console copied to clipboard
OCPBUGS-33383: Fix Admission webhook warning for Route and BuildConfig creation via import flow
Fix: https://issues.redhat.com/browse/OCPBUGS-33383
Descriptions: The unknown field gets added to Route and BuildConfig while creating using the import from git flow. This PR fixes and removes the unknown field from the Route and BuidConfig.
Before:
https://github.com/openshift/console/assets/2561818/6b8ed418-dc20-4776-9b75-19ea80121c22
After:
https://github.com/openshift/console/assets/2561818/d0e5854f-a7d9-4a49-aaf5-0a843e860419
@vikram-raj: This pull request references Jira Issue OCPBUGS-33383, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Fix: https://issues.redhat.com/browse/OCPBUGS-33383
Descriptions: The unknown field gets added to Route and BuildConfig while creating using the import from git flow. This PR fixes and removes the unknown field from the Route and BuidConfig.
Before:
https://github.com/openshift/console/assets/2561818/6b8ed418-dc20-4776-9b75-19ea80121c22
After:
https://github.com/openshift/console/assets/2561818/d0e5854f-a7d9-4a49-aaf5-0a843e860419
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/jira refresh
@vikram-raj: This pull request references Jira Issue OCPBUGS-33383, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/cc @jerolimov
@Lucifergene Updated the PR PTAL. Thanks
/retest
/retest
/retest
/retest
/retest
/retest
/label acknowledge-critical-fixes-only
/retest-required
Remaining retests: 0 against base HEAD a9a6aa4d5c665d5d830da0a8115af7bd5c1b6f73 and 2 for PR HEAD aaa673b4d941a2c2f40fc5194cc7bf0a261d15c5 in total
/retest-required
Remaining retests: 0 against base HEAD 58f2837f19d591c67c5102f8d908ed35ea51ed1d and 1 for PR HEAD aaa673b4d941a2c2f40fc5194cc7bf0a261d15c5 in total
/retest
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
@openshift-bot: This pull request references Jira Issue OCPBUGS-33383, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
In response to this:
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD 1895518823d23fd421accbc567034aad24db5778 and 0 for PR HEAD aaa673b4d941a2c2f40fc5194cc7bf0a261d15c5 in total
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
@openshift-bot: This pull request references Jira Issue OCPBUGS-33383, which is invalid:
- expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/jira refresh /retest
@vikram-raj: This pull request references Jira Issue OCPBUGS-33383, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.17.0) matches configured target version for branch (4.17.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
In response to this:
/jira refresh /retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/hold
Revision aaa673b4d941a2c2f40fc5194cc7bf0a261d15c5 was retested 3 times: holding
/unhold
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Lucifergene, vikram-raj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/dev-console/OWNERS~~ [Lucifergene,vikram-raj]
- ~~frontend/packages/knative-plugin/OWNERS~~ [Lucifergene,vikram-raj]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@vikram-raj: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@vikram-raj: Jira Issue OCPBUGS-33383: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-33383 has been moved to the MODIFIED state.
In response to this:
Fix: https://issues.redhat.com/browse/OCPBUGS-33383
Descriptions: The unknown field gets added to Route and BuildConfig while creating using the import from git flow. This PR fixes and removes the unknown field from the Route and BuidConfig.
Before:
https://github.com/openshift/console/assets/2561818/6b8ed418-dc20-4776-9b75-19ea80121c22
After:
https://github.com/openshift/console/assets/2561818/d0e5854f-a7d9-4a49-aaf5-0a843e860419
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/cherry-pick release-4.16
@vikram-raj: new pull request created: #13881
In response to this:
/cherry-pick release-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.