console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-32698: Remove TELEMETRY_DISABLED check from console telemetry…

Open TheRealJon opened this issue 9 months ago • 6 comments

… plugin listener.

The extension will not be loaded when TELEMETRY_DISABLED is set to true, so the check is redundant.

TheRealJon avatar Apr 30 '24 18:04 TheRealJon

@TheRealJon: This pull request references Jira Issue OCPBUGS-32698, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

… plugin listener.

The extension will not be loaded when TELEMETRY_DISABLED is set to true, so the check is redundant.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 30 '24 18:04 openshift-ci-robot

/jira refresh

TheRealJon avatar May 01 '24 13:05 TheRealJon

@TheRealJon: This pull request references Jira Issue OCPBUGS-32698, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 01 '24 13:05 openshift-ci-robot

/retest

cluster install failure

TheRealJon avatar May 01 '24 13:05 TheRealJon

/lgtm

sg00dwin avatar May 29 '24 19:05 sg00dwin

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sg00dwin, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 29 '24 19:05 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 03d0d6dfac3eee51ddfee013bf8d02ef1cd463da and 2 for PR HEAD 4235cfdb8a0154ad97e85ab3b6235680bd8571b1 in total

openshift-ci-robot avatar May 30 '24 10:05 openshift-ci-robot

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 30 '24 14:05 openshift-ci[bot]

@TheRealJon: Jira Issue OCPBUGS-32698: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32698 has been moved to the MODIFIED state.

In response to this:

… plugin listener.

The extension will not be loaded when TELEMETRY_DISABLED is set to true, so the check is redundant.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 30 '24 17:05 openshift-ci-robot

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202405302016.p0.g8417bf2.assembly.stream.el9 for distgit openshift-enterprise-console. All builds following this will include this PR.

openshift-bot avatar May 30 '24 21:05 openshift-bot