OCPBUGS-32631: TaskRuns should not be fetched for Failed PLR's

[lokanandaprabhu]

Fixes: https://issues.redhat.com/browse/OCPBUGS-32631

Analysis / Root cause: TaskRuns were fetched for Failed PipelineRuns. Due to this many API calls were happening and performance becoming slow.

Solution Description: Not fetching TaskRuns for Failed PipelineRuns. Now TaskRuns status will be calculated from the message value in pipelinerun.status.conditions. Only on click of Failed status to see the logs TaskRuns are fetched for that PipelineRun

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/102503482/7fe90904-ff77-4fb4-8eaa-1631349fac2c

Unit test coverage report: NA

Test setup:

1.Create 1000 PipelineRuns using https://github.com/openshift-dev-console/loadtests and test different scenarios 


 

Browser conformance:

• [x] Chrome
• [ ] Firefox
• [ ] Safari
• [ ] Edge

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32631, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-32631

Analysis / Root cause: TaskRuns were fetched for Failed PipelineRuns. Due to this many API calls were happening and performance becoming slow.

Solution Description: Not fetching TaskRuns for Failed PipelineRuns. Now TaskRuns status will be calculated from the message value in pipelinerun.status.conditions. Only on click of Failed status to see the logs TaskRuns are fetched for that PipelineRun

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/102503482/7fe90904-ff77-4fb4-8eaa-1631349fac2c

Unit test coverage report: NA

Test setup:

1.Create 1000 PipelineRuns using https://github.com/openshift-dev-console/loadtests and test different scenarios

Browser conformance:

• [x] Chrome
• [ ] Firefox
• [ ] Safari
• [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/cc @jerolimov @karthikjeeyar @vikram-raj

[lokanandaprabhu]

One issue I am facing now is for 1st few Failed PLR's log snippet is loading properly but if I scroll down and click on Failed status until I move my cursor I am not able to see the log snippet. If I move cursor little bit then everything is working

https://github.com/openshift/console/assets/102503482/ec960fe4-27a4-4eb1-83d9-67067c38882b

[lokanandaprabhu]

Hi @jerolimov @vikram-raj @karthikjeeyar ,

I resolved the above issue. PTAL.

[vikram-raj]

/retest

[lokanandaprabhu]

Hi @jerolimov ,

I have updated the PR based on review comments. PTAL.

[lokanandaprabhu]

/retest

[lokanandaprabhu]

/retest

[lokanandaprabhu]

/retest

[lokanandaprabhu]

/jira refresh

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32631, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/retest

[lokanandaprabhu]

Hi @jerolimov / @vikram-raj / @karthikjeeyar ,

Can you PTAL into this. If things are fine I will add the changes to dynamic plugin as well. Thanks.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~frontend/packages/pipelines-plugin/OWNERS~~ [lokanandaprabhu,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[vikram-raj]

/label acknowledge-critical-fixes-only

[openshift-ci[bot]]

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@lokanandaprabhu: Jira Issue OCPBUGS-32631: All pull requests linked via external trackers have merged:

• openshift/console#13806

Jira Issue OCPBUGS-32631 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-32631

Analysis / Root cause: TaskRuns were fetched for Failed PipelineRuns. Due to this many API calls were happening and performance becoming slow.

Solution Description: Not fetching TaskRuns for Failed PipelineRuns. Now TaskRuns status will be calculated from the message value in pipelinerun.status.conditions. Only on click of Failed status to see the logs TaskRuns are fetched for that PipelineRun

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/102503482/7fe90904-ff77-4fb4-8eaa-1631349fac2c

Unit test coverage report: NA

Test setup:

1.Create 1000 PipelineRuns using https://github.com/openshift-dev-console/loadtests and test different scenarios

Browser conformance:

• [x] Chrome
• [ ] Firefox
• [ ] Safari
• [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@lokanandaprabhu: new pull request created: #13863

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202405162013.p0.g58f2837.assembly.stream.el9 for distgit openshift-enterprise-console. All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-05-17-180525