console
console copied to clipboard
openshift
WIP: Make the console display an informative page when no auth source is configured
This is a different take on https://github.com/openshift/console/pull/13713.
The PR splits CSRF identification from authentication as these are generally two separate concepts. There are generalization fixes that leverage the ability of static user authentication to be used as yet another authenticator.
The k8s-auth flag is deprecated and setting it no longer does anything. This removes a single use-case of a development pod running inside of the cluster with k8s-auth being set to "service-account". This behavior can be emulated by using the SA token directly. As an alternative, we could add a "k8s-auth-bearer-token-file" option. This would've likely been a better idea than having the token be pasted in options as we do nowadays.
/assign @jhadvig
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: stlaz Once this PR has been reviewed and has the lgtm label, please assign florkbr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@stlaz: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@stlaz: Closed this PR.
In response to this:
/close superseded by https://github.com/openshift/console/pull/13713
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.