console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-32950: Restore user toggle when authentification is disabled

Open christoph-jerolimov opened this issue 1 year ago • 10 comments

All versions up to 4.14 (local console without authentication):

image

4.15 and 4.16 (local console without authentication):

image

Local console with this PR (and without authentication):

image

/cc @jhadvig @TheRealJon @lokanandaprabhu @Lucifergene

christoph-jerolimov avatar Apr 25 '24 09:04 christoph-jerolimov

@jerolimov: This pull request references Jira Issue OCPBUGS-32950, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

4.14 (local console without authentication):

image

4.15 and 4.16 (local console without authentication):

image

Local console with this PR (and without authentication):

image

/cc @jhadvig @TheRealJon @lokanandaprabhu @Lucifergene

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 25 '24 09:04 openshift-ci-robot

/jira refresh /cherry-pick release-4.15

christoph-jerolimov avatar Apr 25 '24 09:04 christoph-jerolimov

@jerolimov: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/jira refresh /cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov: This pull request references Jira Issue OCPBUGS-32950, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

/jira refresh /cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 25 '24 09:04 openshift-ci-robot

@jerolimov: This pull request references Jira Issue OCPBUGS-32950, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

All versions up to 4.14 (local console without authentication):

image

4.15 and 4.16 (local console without authentication):

image

Local console with this PR (and without authentication):

image

/cc @jhadvig @TheRealJon @lokanandaprabhu @Lucifergene

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 25 '24 09:04 openshift-ci-robot

/retest

christoph-jerolimov avatar Apr 26 '24 05:04 christoph-jerolimov

/retest

christoph-jerolimov avatar Apr 26 '24 22:04 christoph-jerolimov

/retest

christoph-jerolimov avatar Apr 29 '24 10:04 christoph-jerolimov

/retest

christoph-jerolimov avatar May 16 '24 06:05 christoph-jerolimov

/retest

christoph-jerolimov avatar May 27 '24 10:05 christoph-jerolimov

/cherry-pick release-4.16 release-4.15

christoph-jerolimov avatar May 27 '24 10:05 christoph-jerolimov

@jerolimov: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16 release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/retest

jhadvig avatar May 27 '24 10:05 jhadvig

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 27 '24 10:05 openshift-ci[bot]

/retest

christoph-jerolimov avatar May 27 '24 14:05 christoph-jerolimov

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 27 '24 20:05 openshift-ci[bot]

@jerolimov: Jira Issue OCPBUGS-32950: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32950 has been moved to the MODIFIED state.

In response to this:

All versions up to 4.14 (local console without authentication):

image

4.15 and 4.16 (local console without authentication):

image

Local console with this PR (and without authentication):

image

/cc @jhadvig @TheRealJon @lokanandaprabhu @Lucifergene

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 27 '24 20:05 openshift-ci-robot

@jerolimov: #13797 failed to apply on top of branch "release-4.15":

Applying: Restore user toggle when authentification is disabled
Using index info to reconstruct a base tree...
M	frontend/public/components/masthead-toolbar.jsx
M	frontend/public/locales/en/public.json
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/locales/en/public.json
Auto-merging frontend/public/components/masthead-toolbar.jsx
CONFLICT (content): Merge conflict in frontend/public/components/masthead-toolbar.jsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Restore user toggle when authentification is disabled
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/jira refresh /cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jerolimov: new pull request created: #13902

In response to this:

/cherry-pick release-4.16 release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202405281343.p0.g821b63e.assembly.stream.el9 for distgit openshift-enterprise-console. All builds following this will include this PR.

openshift-bot avatar May 29 '24 01:05 openshift-bot