console
console copied to clipboard
openshift
[release-4.15] OCPBUGS-32793: Fix that telemetry events didn't incl. an userId anymore
Fixes: https://issues.redhat.com/browse/OCPBUGS-32793
This is a manual backport of https://issues.redhat.com/browse/OCPBUGS-32791, the fix for that is included in #13786
Cluster bot 4.14
By default, no telemetry communication happens.
After setting these annotations on the console cluster config (Console CR, not ConfigMap):
telemetry.console.openshift.io/SEGMENT_API_KEY: ...
telemetry.console.openshift.io/SEGMENT_API_HOST: console.redhat.com/connections/api/v1
telemetry.console.openshift.io/SEGMENT_JS_HOST: console.redhat.com/connections/cdn
telemetry.console.openshift.io/ORGANIZATION_ID: console-team-cluster-bot-test
I could confirm this network communication:
When also adding
telemetry.console.openshift.io/DEBUG: 'true'
The scripts are still loaded, but the events are not sent.
The Segment userId is sha1('kube:admin')
Cluster bot 4.15
By default, no telemetry communication happens.
After setting these annotations on the console cluster config (Console CR, not ConfigMap):
telemetry.console.openshift.io/SEGMENT_API_KEY: ...
telemetry.console.openshift.io/SEGMENT_API_HOST: console.redhat.com/connections/api/v1
telemetry.console.openshift.io/SEGMENT_JS_HOST: console.redhat.com/connections/cdn
telemetry.console.openshift.io/ORGANIZATION_ID: console-team-cluster-bot-test
I could confirm this network communication:
When also adding
telemetry.console.openshift.io/DEBUG: 'true'
The scripts are still loaded, but the events are not sent.
The Segment userId is picked up from the ajs_user_id cookie, or null if the cookie isn't there.
@jerolimov: This pull request references Jira Issue OCPBUGS-32793, which is invalid:
- release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
- expected Jira Issue OCPBUGS-32793 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Fixes: https://issues.redhat.com/browse/OCPBUGS-32793
This is a manual backport of https://issues.redhat.com/browse/OCPBUGS-32791, the fix for that is included in #13786
todo, will test and compare 4.14, 4.15 and this PR here...
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
@vikram-raj: This pull request references Jira Issue OCPBUGS-32793, which is invalid:
- release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
- expected Jira Issue OCPBUGS-32793 to depend on a bug targeting a version in 4.16.0, 4.16.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@vikram-raj: This pull request references Jira Issue OCPBUGS-32793, which is valid. The bug has been moved to the POST state.
7 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.15.z) matches configured target version for branch (4.15.z)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
- release note type set to "Release Note Not Required"
- dependent bug Jira Issue OCPBUGS-32791 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
- dependent Jira Issue OCPBUGS-32791 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0, 4.16.z
- bug has dependents
Requesting review from QA contact: /cc @sanketpathak
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jerolimov, vikram-raj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~dynamic-demo-plugin/OWNERS~~ [jerolimov]
- ~~frontend/OWNERS~~ [jerolimov,vikram-raj]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jerolimov: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.15.0-202409121137.p0.g5d6978c.assembly.stream.el8. All builds following this will include this PR.