console
console copied to clipboard
openshift
OCPBUGS-19048: Fix perspective detection for dynamic route extensions and url query params
- Update useActivePerspective hook. SetActivePerspective callback accepts a second argument, "next". If passed, we use it in place of "/" as the navigate destination after updating the perspective.
- Update DetectPerspective to use the current location pathname as the second argument to setActivePerspective when a "perspective" URL query param is defined. This means that we redirect to the same location after changing the perspective, rather than the base path.
- Update app-content route page extension handling for better separation and readability.
- Update inactive route page extensions to use the second arg to set active perspective. They now pass their path property into setActivePerspective so that after changing the perspective, the app redirects back to the route that caused the change, which is now an active route page plugin.
@TheRealJon: This pull request references Jira Issue OCPBUGS-19048, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@TheRealJon: This pull request references Jira Issue OCPBUGS-19048, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rhamilto, TheRealJon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [TheRealJon,rhamilto]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/retest-required
Remaining retests: 0 against base HEAD 03d0d6dfac3eee51ddfee013bf8d02ef1cd463da and 2 for PR HEAD 0101f95781618f2faf69409b59a29ba4c0c9572f in total
/retest-required
Remaining retests: 0 against base HEAD 8417bf2a9a3adae7528f5273fb5f746d3caca115 and 1 for PR HEAD 0101f95781618f2faf69409b59a29ba4c0c9572f in total
/retest-required
Remaining retests: 0 against base HEAD f3446a70b78bbe7ef53411882bbe4d5af0c434c0 and 0 for PR HEAD 0101f95781618f2faf69409b59a29ba4c0c9572f in total
/hold
Revision 0101f95781618f2faf69409b59a29ba4c0c9572f was retested 3 times: holding
/retest-required
Remaining retests: 0 against base HEAD 4a4ae1254473e5553c636baae8c60f941b1f0782 and 2 for PR HEAD 0101f95781618f2faf69409b59a29ba4c0c9572f in total
@TheRealJon: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@TheRealJon: Jira Issue OCPBUGS-19048: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-19048 has been moved to the MODIFIED state.
In response to this:
- Update useActivePerspective hook. SetActivePerspective callback accepts a second argument, "next". If passed, we use it in place of "/" as the navigate destination after updating the perspective.
- Update DetectPerspective to use the current location pathname as the second argument to setActivePerspective when a "perspective" URL query param is defined. This means that we redirect to the same location after changing the perspective, rather than the base path.
- Update app-content route page extension handling for better separation and readability.
- Update inactive route page extensions to use the second arg to set active perspective. They now pass their path property into setActivePerspective so that after changing the perspective, the app redirects back to the route that caused the change, which is now an active route page plugin.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.