console
console copied to clipboard
openshift
OCPBUGS-32405: Create Serverless form does not create BuildConfig
Fixes: https://issues.redhat.com/browse/OCPBUGS-32405
Analysis / Root cause: When pipeline operator is not installed and Pipeline resource is not created for that particular serverless function then BuildConfig is not created
Solution Description: Updated to consider build option as BUILDS when pipeline is not checked and if pipeline is checked, build option will be PIPELINES.
Screen shots / Gifs for design review:
----Without pipeline operator installed---- https://github.com/openshift/console/assets/102503482/6391cd11-b582-497a-9ca0-4ed1eab8e3ef
----With pipeline operator installed and without Pipeline resource----
https://github.com/openshift/console/assets/102503482/ad81ee1a-e5ff-42ee-8616-5c661d7407d0
----With pipeline operator installed and with Pipeline resource----
https://github.com/openshift/console/assets/102503482/792e8161-dd1e-469d-999f-12c5712fac1c
----With pipeline operator installed and with Pipeline resource but unchecked add pipeline----
https://github.com/openshift/console/assets/102503482/85dcf4fa-90a4-4d30-a652-754a6b2f155f
---with Samples---- https://github.com/openshift/console/assets/102503482/b49ba0a7-638a-4d2e-b5d5-daace0329e51
Unit test coverage report: NA
Test setup:
1.Install serverless operator and knative instances
2. Don't install pipelines operator
3. Create serverless function, then BuildConfig should be created
4. Install Pipelines operator but don't create Pipeline resource for particular serverless function and create serverless function, then also BuildConfig should be created
5. Create Pipeline resource using https://gist.github.com/vikram-raj/386b4eca5193036b0ca29471f6e513a5 and create serverless function, then if you select add pipelines then Pipeline/Repository will be created and if you don't add pipeline, then BuildConfig will be created
Browser conformance:
- [x] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Edge
@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32405, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Fixes: https://issues.redhat.com/browse/OCPBUGS-32405
Analysis / Root cause: When pipeline operator is not installed and Pipeline resource is not created for that particular serverless function then BuildConfig is not created
Solution Description: Updated to consider build option as BUILDS when pipeline is not checked and if pipeline is checked, build option will be PIPELINES.
Screen shots / Gifs for design review:
----Without pipeline operator installed---- https://github.com/openshift/console/assets/102503482/6391cd11-b582-497a-9ca0-4ed1eab8e3ef
----With pipeline operator installed and without Pipeline resource----
https://github.com/openshift/console/assets/102503482/ad81ee1a-e5ff-42ee-8616-5c661d7407d0
----With pipeline operator installed and with Pipeline resource----
https://github.com/openshift/console/assets/102503482/792e8161-dd1e-469d-999f-12c5712fac1c
----With pipeline operator installed and with Pipeline resource but unchecked add pipeline----
https://github.com/openshift/console/assets/102503482/85dcf4fa-90a4-4d30-a652-754a6b2f155f
---with Samples---- https://github.com/openshift/console/assets/102503482/b49ba0a7-638a-4d2e-b5d5-daace0329e51
Unit test coverage report: NA
Test setup:
1.Install serverless operator and knative instances 2. Don't install pipelines operator 3. Create serverless function, then BuildConfig should be created 4. Install Pipelines operator but don't create Pipeline resource for particular serverless function and create serverless function, then also BuildConfig should be created 5. Create Pipeline resource using https://gist.github.com/vikram-raj/386b4eca5193036b0ca29471f6e513a5 and create serverless function, then if you select add pipelines then Pipeline/Repository will be created and if you don't add pipeline, then BuildConfig will be created
Browser conformance:
- [x] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Edge
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32405, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@lokanandaprabhu: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @jerolimov ,
Sure, we can align the UI with other import flows but can we handle it in separate ticket since this issue is targeting Serverless form not creating BC and it is critical. I can create separate ticket for the same.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lokanandaprabhu, vikram-raj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/dev-console/OWNERS~~ [lokanandaprabhu,vikram-raj]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
@openshift-bot: This pull request references Jira Issue OCPBUGS-32405, which is invalid:
- expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32405, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.17.0) matches configured target version for branch (4.17.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@lokanandaprabhu: Jira Issue OCPBUGS-32405: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-32405 has been moved to the MODIFIED state.
In response to this:
Fixes: https://issues.redhat.com/browse/OCPBUGS-32405
Analysis / Root cause: When pipeline operator is not installed and Pipeline resource is not created for that particular serverless function then BuildConfig is not created
Solution Description: Updated to consider build option as BUILDS when pipeline is not checked and if pipeline is checked, build option will be PIPELINES.
Screen shots / Gifs for design review:
----Without pipeline operator installed---- https://github.com/openshift/console/assets/102503482/6391cd11-b582-497a-9ca0-4ed1eab8e3ef
----With pipeline operator installed and without Pipeline resource----
https://github.com/openshift/console/assets/102503482/ad81ee1a-e5ff-42ee-8616-5c661d7407d0
----With pipeline operator installed and with Pipeline resource----
https://github.com/openshift/console/assets/102503482/792e8161-dd1e-469d-999f-12c5712fac1c
----With pipeline operator installed and with Pipeline resource but unchecked add pipeline----
https://github.com/openshift/console/assets/102503482/85dcf4fa-90a4-4d30-a652-754a6b2f155f
---with Samples---- https://github.com/openshift/console/assets/102503482/b49ba0a7-638a-4d2e-b5d5-daace0329e51
Unit test coverage report: NA
Test setup:
1.Install serverless operator and knative instances 2. Don't install pipelines operator 3. Create serverless function, then BuildConfig should be created 4. Install Pipelines operator but don't create Pipeline resource for particular serverless function and create serverless function, then also BuildConfig should be created 5. Create Pipeline resource using https://gist.github.com/vikram-raj/386b4eca5193036b0ca29471f6e513a5 and create serverless function, then if you select add pipelines then Pipeline/Repository will be created and if you don't add pipeline, then BuildConfig will be created
Browser conformance:
- [x] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Edge
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@lokanandaprabhu: new pull request created: #13885
In response to this:
/cherrypick release-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
