WIP: CONSOLE-3824: Remove kubevirt-plugin code

[pcbailey]

This PR does the following:

• Removes the kubevirt-plugin package and references in configuration files
• Copies code upon which the topology plugin is dependent from the kubevirt-plugin package to the topology package
• Changed the i18n prefix in the network-attachment-definition-plugin package from kubevirt-plugin to network-attachment-definition-plugin

Jira: https://issues.redhat.com/browse/CONSOLE-3824

[openshift-ci-robot]

@pcbailey: This pull request references CONSOLE-3824 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR does the following:

• Removes the kubevirt-plugin package and references in configuration files
• Copies code upon which the topology plugin is dependent from the kubevirt-plugin package to the topology package
• Changed the i18n prefix in the network-attachment-definition-plugin package from kubevirt-plugin to network-attachment-definition-plugin

Jira: https://issues.redhat.com/browse/CONSOLE-3824

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[avivtur]

This PR will also solve: https://issues.redhat.com//browse/CNV-37607

[pcbailey]

/retest

[pcbailey]

/retest

[avivtur]

Excellent work @pcbailey :1st_place_medal: /lgtm

[jhadvig]

QE Approver: /assign @yapei Docs Approver: /assign @opayne1 PX Approver: /assign @RickJWagner

[RickJWagner]

/label px-approved

[yapei]

1. launched a cluster, subscribed OpenShift Virtualization operator successfully
2. Verify Virtualization menu exists
3. Verify if secondary menu Network Attachment Definitions exist in Networking menu -> No Network Attachment Definitions menu, see screen recording

https://github.com/openshift/console/assets/12692381/0c1af56c-3e3b-4af8-808a-d5ed7f6618e9

[yapei]

also due to https://issues.redhat.com/browse/OCPBUGS-22853 I can't verify if VM topology codes are working as expected or not(these codes moved away from frontend/packages/kubevirt-plugin/src/topology to frontend/packages/topology ) since VirtualMachines page is not accessible

[pcbailey]

1. launched a cluster, subscribed OpenShift Virtualization operator successfully
2. Verify Virtualization menu exists
3. Verify if secondary menu Network Attachment Definitions exist in Networking menu -> No Network Attachment Definitions menu, see screen recording

I fixed this issue. It was looking for the KUBEVIRT flag, so I updated it to look for the KUBEVIRT_DYNAMIC flag.

[pcbailey]

also due to https://issues.redhat.com/browse/OCPBUGS-22853 I can't verify if VM topology codes are working as expected or not(these codes moved away from frontend/packages/kubevirt-plugin/src/topology to frontend/packages/topology ) since VirtualMachines page is not accessible

I'm not sure I understand what you mean. That bug pertains to OCP 4.14/CNV 4.13. I also confirmed that the root cause of that bug is no longer present in our code from 4.14 onward. I was able to test the Topology page and Virtual Machines pages. Could you please clarify the issue you mention here? Thanks!

[pcbailey]

/retest

[pcbailey]

/retest

[pcbailey]

/retest

[avivtur]

/lgtm

[pcbailey]

/retest

[pcbailey]

/retest

[pcbailey]

/retest

[pcbailey]

/retest

[yapei]

I still can't visit VirtualMachines page and other pages(OpenShift Virtualization 4.14.0 installed), here is the recording

https://github.com/openshift/console/assets/12692381/8088a280-81bf-46fd-8be6-22e935d30231

[pcbailey]

I still can't visit VirtualMachines page and other pages(OpenShift Virtualization 4.14.0 installed), here is the recording

Ah, I understand now. This PR should be tested on the latest versions of OCP and OpenShift Virtualization.

[yapei]

generally the changes look good from QE's point of view /label qe-approved

[openshift-ci-robot]

@pcbailey: This pull request references CONSOLE-3824 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

This PR does the following:

• Removes the kubevirt-plugin package and references in configuration files
• Copies code upon which the topology plugin is dependent from the kubevirt-plugin package to the topology package
• Changed the i18n prefix in the network-attachment-definition-plugin package from kubevirt-plugin to network-attachment-definition-plugin

Jira: https://issues.redhat.com/browse/CONSOLE-3824

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pcbailey]

/retest

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, jhadvig, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~frontend/OWNERS~~ [jhadvig]
• ~~pkg/OWNERS~~ [jhadvig]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment