MULTIARCH-4148: Add the CPU architecture column to the NodeList and filter properties for all cpu archs
This will have CPU arch column to console and filter properties for all CPU archs . Here are some screenshot of it .
@pkenchap: This pull request references MULTIARCH-4148 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.
In response to this:
This will have CPU arch column to console and filter properties for all CPU archs . Here are some screenshot of it .
![]()
![]()
![]()
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@prb112, I have your changes as well in this PR , because my changes uses your code and its in the same file .
@prb112 @jeffdyoung @jeremyfreudberg Please take a look .
/test e2e-gcp-console
/test images
/test e2e-gcp-console
/retest-required
@spadgett and @TheRealJon , Appriceate for reviewing the code and suggesting changes .
I had modified the code as suggested above and tested it and it works. Please do take a look at the PR once again.
cc: @prb112
Screenshot:
Thanks, Punith
@spadgett and @TheRealJon Thanks for your recommendations . PTAL .
Screenshot:
@rawagner @spadgett @TheRealJon, Thanks for your suggestions , Modified the code accordingly, PTAL.
cc: @prb112 Thanks, Punith
Hi @rawagner @spadgett @TheRealJon .
I had modified as recommended , PTAL.
Thanks, Punith
/test e2e-gcp-console
/test images
/test e2e-gcp-console
/test e2e-gcp-console
Hi @rawagner @spadgett @TheRealJon . PTAL.
Thanks, Punith
Hi @TheRealJon I had addressed the comments , could you PTAL.
Thanks, Punith
/lgtm
/lgtm
Nice job /lgtm
Hey @jrthms and @stevsmit could you review for px/docs? Thanks, paul
/lgtm
@jrthms: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/label docs-approved
Hi @yapei
We request your review and approval as qe-approved for this PR would be greatly appreciated.
Thanks, Punith
@pkenchap tested the PR and found some issues
-
sorting on
Architecturecolumn seems not working correctly -
with new added
Architecturecolumn, totally 10 columns are shown by default, however it's recommended and limited that only up to 9 columns can be selected in manage columns dialog, shall we remove one column to be consistent in the design or change the description in manage column modal?
@yapei , Thanks for your comments . I had addressed sorting issue. For the other issue we are seeking an inputs from the UI design team.
Here is the screenshot of sorting issue is resolved .
@yapei , we have addressed both issues, please review and provide your approvals. Thanks, Punith
/label qe-approved