console icon indicating copy to clipboard operation
console copied to clipboard

MULTIARCH-4148: Add the CPU architecture column to the NodeList and filter properties for all cpu archs

Open pkenchap opened this issue 1 year ago • 13 comments

This will have CPU arch column to console and filter properties for all CPU archs . Here are some screenshot of it .

Screenshot 2024-04-01 at 3 32 07 PM Screenshot 2024-04-01 at 3 33 06 PM Screenshot 2024-04-01 at 3 33 54 PM

pkenchap avatar Apr 03 '24 07:04 pkenchap

@pkenchap: This pull request references MULTIARCH-4148 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

This will have CPU arch column to console and filter properties for all CPU archs . Here are some screenshot of it .

Screenshot 2024-04-01 at 3 32 07 PM Screenshot 2024-04-01 at 3 33 06 PM Screenshot 2024-04-01 at 3 33 54 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 03 '24 07:04 openshift-ci-robot

@prb112, I have your changes as well in this PR , because my changes uses your code and its in the same file .

pkenchap avatar Apr 03 '24 07:04 pkenchap

@prb112 @jeffdyoung @jeremyfreudberg Please take a look .

pkenchap avatar Apr 03 '24 07:04 pkenchap

/test e2e-gcp-console

prb112 avatar Apr 05 '24 16:04 prb112

/test images

pkenchap avatar Apr 16 '24 08:04 pkenchap

/test e2e-gcp-console

pkenchap avatar Apr 16 '24 08:04 pkenchap

/retest-required

prb112 avatar Apr 16 '24 16:04 prb112

@spadgett and @TheRealJon , Appriceate for reviewing the code and suggesting changes .

I had modified the code as suggested above and tested it and it works. Please do take a look at the PR once again.

cc: @prb112

Screenshot:

Screenshot 2024-06-21 at 1 44 09 PM

Thanks, Punith

pkenchap avatar Jun 21 '24 08:06 pkenchap

@spadgett and @TheRealJon Thanks for your recommendations . PTAL .

Screenshot: Screenshot 2024-06-24 at 12 08 15 PM

pkenchap avatar Jun 24 '24 06:06 pkenchap

@rawagner @spadgett @TheRealJon, Thanks for your suggestions , Modified the code accordingly, PTAL.

cc: @prb112 Thanks, Punith

pkenchap avatar Jun 26 '24 05:06 pkenchap

Hi @rawagner @spadgett @TheRealJon .

I had modified as recommended , PTAL.

Thanks, Punith

pkenchap avatar Jul 01 '24 09:07 pkenchap

/test e2e-gcp-console

pkenchap avatar Jul 15 '24 08:07 pkenchap

/test images

pkenchap avatar Jul 15 '24 08:07 pkenchap

/test e2e-gcp-console

pkenchap avatar Jul 16 '24 06:07 pkenchap

/test e2e-gcp-console

pkenchap avatar Jul 17 '24 04:07 pkenchap

Hi @rawagner @spadgett @TheRealJon . PTAL.

Thanks, Punith

pkenchap avatar Jul 17 '24 05:07 pkenchap

Hi @TheRealJon I had addressed the comments , could you PTAL.

Thanks, Punith

pkenchap avatar Jul 23 '24 05:07 pkenchap

/lgtm

rawagner avatar Aug 01 '24 06:08 rawagner

/lgtm

rawagner avatar Aug 01 '24 07:08 rawagner

Nice job /lgtm

prb112 avatar Aug 01 '24 13:08 prb112

Hey @jrthms and @stevsmit could you review for px/docs? Thanks, paul

prb112 avatar Aug 01 '24 14:08 prb112

/lgtm

jrthms avatar Aug 01 '24 14:08 jrthms

@jrthms: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 01 '24 14:08 openshift-ci[bot]

/label docs-approved

alishaIBM avatar Aug 02 '24 05:08 alishaIBM

Hi @yapei

We request your review and approval as qe-approved for this PR would be greatly appreciated.

Thanks, Punith

pkenchap avatar Aug 05 '24 12:08 pkenchap

@pkenchap tested the PR and found some issues

  1. sorting on Architecture column seems not working correctly Screenshot 2024-08-06 at 5 38 39 PM

  2. with new added Architecture column, totally 10 columns are shown by default, however it's recommended and limited that only up to 9 columns can be selected in manage columns dialog, shall we remove one column to be consistent in the design or change the description in manage column modal? Screenshot 2024-08-06 at 5 54 37 PM

yapei avatar Aug 06 '24 09:08 yapei

@yapei , Thanks for your comments . I had addressed sorting issue. For the other issue we are seeking an inputs from the UI design team.

pkenchap avatar Aug 06 '24 13:08 pkenchap

Here is the screenshot of sorting issue is resolved . Screenshot 2024-08-06 at 6 46 08 PM

pkenchap avatar Aug 06 '24 13:08 pkenchap

@yapei , we have addressed both issues, please review and provide your approvals. Thanks, Punith

pkenchap avatar Aug 07 '24 04:08 pkenchap

/label qe-approved

yapei avatar Aug 07 '24 08:08 yapei