console
console copied to clipboard
openshift
[WIP]CONSOLE-3989: Display a warning message from kube-apiserver when creating workloads resource for Create YAML Editor
@cyril-ui-developer: This pull request references CONSOLE-3939 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
NOT READY FOR REVIEW
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@cyril-ui-developer: This pull request references CONSOLE-3989 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.
In response to this:
NOT READY FOR REVIEW
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@cyril-ui-developer: This pull request references CONSOLE-3989 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@cyril-ui-developer: This pull request references CONSOLE-3989 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.
In response to this:
Steps to verify the warn policy.
- Create a Validation Admission Webhook to enforce a warn policy for resource i.e. Pod, Deployment . For example, you can follow the steps in my GIst
- Create the resource specified in the warn policy in step 1 i.e. Pod using Create YAML editor to see the notification alert.
After:
Scenario 1:
Scenario 2:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cyril-ui-developer Once this PR has been reviewed and has the lgtm label, please ask for approval from rhamilto. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@cyril-ui-developer: This pull request references CONSOLE-3989 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.
In response to this:
Steps to verify the warn policy.
- Create a Validation Admission Webhook to enforce a warn policy for resource i.e. Pod, Deployment . For example, you can follow the steps in my GIst
- Create the resource specified in the warn policy in step 1 i.e. Pod using Create YAML editor to see the notification alert.
After:
Scenario 1:
Scenario 2:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@cyril-ui-developer: This pull request references CONSOLE-3989 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.
In response to this:
Steps to verify the warn policy.
- Create a Validation Admission Webhook to enforce a warn policy for resource i.e. Pod . For example, you can follow the steps in my GIst
- Create the resource specified in the warn policy in step 1 i.e. Pod using Create YAML editor to see the notification alert. Note: This change covers Import YAML editor for all resources and certain resources i.e. Pod that fully makes use of the Create YAML Editor code implementation in - https://github.com/openshift/console/blob/master/frontend/public/components/edit-yaml.jsx.
After:
Scenario 1:
Scenario 2:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/hold
Let's look again at the public API we've created to expose the full HTTP response and make sure it's what we want.
@cyril-ui-developer: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@cyril-ui-developer: This pull request references CONSOLE-3989 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.
In response to this:
Steps to verify the warn policy.
- Create a Validation Admission Webhook to enforce a warn policy for resource i.e. Pod . For example, you can follow the steps in my GIst
- Create the resource specified in the warn policy in step 1 i.e. Pod using Create YAML editor to see the notification alert. Note: This change covers Import YAML editor for all resources and certain resources i.e. Pod that fully makes use of the Create YAML Editor code implementation in - https://github.com/openshift/console/blob/master/frontend/public/components/edit-yaml.jsx.
After:
Scenario 1:
Scenario 2:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
