console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.14] OCPBUGS-33064: Fix PipelineRun Logs tab navigation

Open vikram-raj opened this issue 1 year ago • 10 comments

Manual cherry-pick of PR https://github.com/openshift/console/pull/13484

vikram-raj avatar Mar 14 '24 18:03 vikram-raj

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lucifergene, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 11 '24 11:04 openshift-ci[bot]

/label backport-risk-assessed

Lucifergene avatar Apr 27 '24 17:04 Lucifergene

@Lucifergene: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 27 '24 17:04 openshift-ci[bot]

/jira refresh

Lucifergene avatar Apr 27 '24 17:04 Lucifergene

@Lucifergene: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 27 '24 17:04 openshift-ci-robot

/retitle [release-4.14] OCPBUGS-33064: Fix PipelineRun Logs tab navigation

Lucifergene avatar Apr 27 '24 17:04 Lucifergene

@vikram-raj: This pull request references Jira Issue OCPBUGS-33064, which is invalid:

  • expected Jira Issue OCPBUGS-33064 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry-pick of PR https://github.com/openshift/console/pull/13484

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 27 '24 17:04 openshift-ci-robot

/jira refresh

Lucifergene avatar Apr 27 '24 17:04 Lucifergene

@Lucifergene: This pull request references Jira Issue OCPBUGS-33064, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-26209 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-26209 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact: /cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 27 '24 17:04 openshift-ci-robot

/label backport-risk-assessed

vikram-raj avatar May 22 '24 10:05 vikram-raj

/cherry-pick release-4.13

vikram-raj avatar May 22 '24 10:05 vikram-raj

@vikram-raj: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/label cherry-pick-approved

The-Anton avatar May 22 '24 12:05 The-Anton

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 22 '24 16:05 openshift-ci[bot]

@vikram-raj: Jira Issue OCPBUGS-33064: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33064 has been moved to the MODIFIED state.

In response to this:

Manual cherry-pick of PR https://github.com/openshift/console/pull/13484

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 22 '24 16:05 openshift-ci-robot

@vikram-raj: #13673 failed to apply on top of branch "release-4.13":

Applying: Fix PipelineRun Logs tab navigation
Using index info to reconstruct a base tree...
M	frontend/packages/pipelines-plugin/src/components/pipelineruns/PipelineRunDetailsPage.tsx
M	frontend/packages/pipelines-plugin/src/components/pipelineruns/detail-page-tabs/PipelineRunLogs.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/pipelines-plugin/src/components/pipelineruns/detail-page-tabs/PipelineRunLogs.tsx
CONFLICT (content): Merge conflict in frontend/packages/pipelines-plugin/src/components/pipelineruns/detail-page-tabs/PipelineRunLogs.tsx
Auto-merging frontend/packages/pipelines-plugin/src/components/pipelineruns/PipelineRunDetailsPage.tsx
CONFLICT (content): Merge conflict in frontend/packages/pipelines-plugin/src/components/pipelineruns/PipelineRunDetailsPage.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix PipelineRun Logs tab navigation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.14.0-202405221708.p0.g48d1a27.assembly.stream.el8 for distgit openshift-enterprise-console. All builds following this will include this PR.

openshift-bot avatar May 22 '24 18:05 openshift-bot

manual cherry-pick PR https://github.com/openshift/console/pull/13890

vikram-raj avatar May 23 '24 10:05 vikram-raj

Fix included in accepted release 4.14.0-0.nightly-2024-05-27-035012

openshift-merge-robot avatar May 27 '24 13:05 openshift-merge-robot