console
console copied to clipboard
openshift
WINC-1182: [node] Modify filesystem queries to include Windows metrics
This commit modifies filesystem queries to account for Windows node metrics which are exported through windows_exporter when Windows nodes are present in a cluster.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@mansikulkarni96 Is there a Jira issue related to this change? We'll need a bug or RFE to merge this.
@mansikulkarni96: This pull request references WINC-1182 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
This commit modifies filesystem queries to account for Windows node metrics which are exported through windows_exporter when Windows nodes are present in a cluster.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@TheRealJon I linked the issue we have on the Windows Containers JIRA board.
A review from the monitoring team would be best. They have much more expertise in PromQL than I do. I can tag and approve it once they have reviewed.
@TheRealJon can you please take a look and approve this if it looks good?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mansikulkarni96, rexagod, TheRealJon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [TheRealJon]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@mansikulkarni96: This pull request references WINC-1182 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "WMCO 10.16.0" instead.
In response to this:
This commit modifies filesystem queries to account for Windows node metrics which are exported through windows_exporter when Windows nodes are present in a cluster.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@mansikulkarni96: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
This PR has been included in build openshift-enterprise-console-container-v4.16.0-202404090113.p0.g9bbf25e.assembly.stream.el9 for distgit openshift-enterprise-console. All builds following this will include this PR.
