console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.14] OCPBUGS-29783: Fix operands list endpoint

Open TheRealJon opened this issue 1 year ago • 11 comments

The operands list endpoint always proxies to the public API server URL instead of the proxy endpoint configured at startup. This causes mismatched TLS configuration when the console runs on-cluster.

Manual cherry-pick of #13633

TheRealJon avatar Feb 21 '24 19:02 TheRealJon

@TheRealJon: This pull request references Jira Issue OCPBUGS-29783, which is invalid:

  • expected Jira Issue OCPBUGS-29783 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The operands list endpoint always proxies to the public API server URL instead of the proxy endpoint configured at startup. This causes mismatched TLS configuration when the console runs on-cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 21 '24 19:02 openshift-ci-robot

/cherry-pick release-4.13

TheRealJon avatar Feb 21 '24 19:02 TheRealJon

@TheRealJon: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/label backport-risk-assessed

TheRealJon avatar Mar 04 '24 16:03 TheRealJon

/jira refresh

TheRealJon avatar Mar 11 '24 18:03 TheRealJon

@TheRealJon: This pull request references Jira Issue OCPBUGS-29783, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29781 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29781 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact: /cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 11 '24 18:03 openshift-ci-robot

/jira refresh

TheRealJon avatar Mar 14 '24 20:03 TheRealJon

@TheRealJon: This pull request references Jira Issue OCPBUGS-29783, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29781 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29781 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 14 '24 20:03 openshift-ci-robot

/lgtm

rhamilto avatar Mar 22 '24 18:03 rhamilto

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 22 '24 18:03 openshift-ci[bot]

  1. setup custom certificate for api server
  2. install and uninstall operators from operatorhub the following error didn't appear
Cannot load Operands

There was an error loading operands for this operator. Operands will need to be deleted manually.
Error loading Operands for amq-streams in default: r: Failed to get new client for listing operands: Get "xxxxx

/label qe-approved /label cherry-pick-approved

yapei avatar Apr 01 '24 06:04 yapei

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 01 '24 10:04 openshift-ci[bot]

@TheRealJon: Jira Issue OCPBUGS-29783: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29783 has been moved to the MODIFIED state.

In response to this:

The operands list endpoint always proxies to the public API server URL instead of the proxy endpoint configured at startup. This causes mismatched TLS configuration when the console runs on-cluster.

Manual cherry-pick of #13633

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 01 '24 10:04 openshift-ci-robot

@TheRealJon: #13625 failed to apply on top of branch "release-4.13":

Applying: OCPBUGS-29783: Fix operands list endpoint.
Using index info to reconstruct a base tree...
M	pkg/server/server.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/server/server.go
CONFLICT (content): Merge conflict in pkg/server/server.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-29783: Fix operands list endpoint.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.14.0-202404010644.p0.g95d769c.assembly.stream.el8 for distgit openshift-enterprise-console. All builds following this will include this PR.

openshift-bot avatar Apr 01 '24 11:04 openshift-bot

Fix included in accepted release 4.14.0-0.nightly-2024-04-01-115651

openshift-merge-robot avatar Apr 01 '24 18:04 openshift-merge-robot