console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.14] OCPBUGS-28746: fix bug where Expand PVC modal assumes pvc.spec.resou…

Open openshift-cherrypick-robot opened this issue 1 year ago • 11 comments

This is an automated cherry-pick of #13542

/assign rhamilto

@openshift-cherrypick-robot: Jira Issue OCPBUGS-27909 has been cloned as Jira Issue OCPBUGS-28746. Will retitle bug to link to clone. /retitle [release-4.14] OCPBUGS-28746: fix bug where Expand PVC modal assumes pvc.spec.resou…

In response to this:

This is an automated cherry-pick of #13542

/assign rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jan 31 '24 15:01 openshift-ci-robot

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28746, which is invalid:

  • expected dependent Jira Issue OCPBUGS-27909 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #13542

/assign rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jan 31 '24 15:01 openshift-ci-robot

/approve /lgtm /label backport-risk-assessed

rhamilto avatar Jan 31 '24 16:01 rhamilto

Checked on cluster launched against the pr, create pvc with spec.requests.storage: "2147483648", check on pvc details page, the "Requested capacity" is 2 GiB. Check on "Expand PVC" modal, it shows 2 GiB. /label qe-approved /label cherry-pick-approved

yanpzhan avatar Feb 28 '24 08:02 yanpzhan

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28746, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27909 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-27909 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

This is an automated cherry-pick of #13542

/assign rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 28 '24 08:02 openshift-ci-robot

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28746, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27909 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-27909 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact: /cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #13542

/assign rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 18 '24 13:03 openshift-ci-robot

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28746. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

This is an automated cherry-pick of #13542

/assign rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 18 '24 13:03 openshift-ci-robot

/jira refresh

rhamilto avatar Mar 18 '24 13:03 rhamilto

@rhamilto: This pull request references Jira Issue OCPBUGS-28746, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-27909 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-27909 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 18 '24 13:03 openshift-ci-robot

/retest

@yapei, mind reviewing and adding approval?

rhamilto avatar Apr 01 '24 19:04 rhamilto

/retest-required

Remaining retests: 0 against base HEAD 95d769c52c907a3dc1ee940ecf1841ea1d5a8f35 and 2 for PR HEAD c7478bcfad4c157e6308b3864bf0a432f5ccd874 in total

openshift-ci-robot avatar Apr 02 '24 00:04 openshift-ci-robot

I see qe-approved and cherry-pick-approved label is already added anyway I tested again and it's working

yapei avatar Apr 02 '24 03:04 yapei

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rhamilto, yapei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 02 '24 03:04 openshift-ci[bot]

/retest

rhamilto avatar Apr 02 '24 11:04 rhamilto

I see qe-approved and cherry-pick-approved label is already added anyway I tested again and it's working

I completely overlooked those labels. Sorry, @yapei! Thank you for retesting!

rhamilto avatar Apr 02 '24 11:04 rhamilto

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 02 '24 15:04 openshift-ci[bot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28746: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28746 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #13542

/assign rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 02 '24 15:04 openshift-ci-robot

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.14.0-202404021308.p0.ge50f3d4.assembly.stream.el8 for distgit openshift-enterprise-console. All builds following this will include this PR.

openshift-bot avatar Apr 02 '24 18:04 openshift-bot

Fix included in accepted release 4.14.0-0.nightly-2024-04-02-185046

openshift-merge-robot avatar Apr 03 '24 00:04 openshift-merge-robot