console icon indicating copy to clipboard operation
console copied to clipboard

[WIP] CONSOLE-3902: External login command modal

Open TheRealJon opened this issue 1 year ago • 6 comments

Still a work in progress

TheRealJon avatar Jan 22 '24 22:01 TheRealJon

@TheRealJon: This pull request references CONSOLE-3902 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Still a work in progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jan 22 '24 22:01 openshift-ci-robot

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Jan 22 '24 22:01 openshift-ci[bot]

/retest

TheRealJon avatar Feb 28 '24 21:02 TheRealJon

/label tide/merge-method-squash

TheRealJon avatar Mar 06 '24 17:03 TheRealJon

@TheRealJon: This pull request references CONSOLE-3902 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Add external OIDC copy login command modal to masthead toolbar and "Command Line Tools" page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot avatar Apr 10 '24 17:04 openshift-bot

QE Approver /assign @yapei

Docs Approver: /assign @opayne1

PX Approver: /assign @RickJWagner

TheRealJon avatar Apr 10 '24 17:04 TheRealJon

@jhadvig This PR is ready for review!

TheRealJon avatar Apr 10 '24 17:04 TheRealJon

/label px-approved

RickJWagner avatar Apr 10 '24 18:04 RickJWagner

/label docs-approved

opayne1 avatar Apr 10 '24 20:04 opayne1

/retest

TheRealJon avatar Apr 11 '24 16:04 TheRealJon

Cluster install failed.

/retest

TheRealJon avatar Apr 12 '24 14:04 TheRealJon

/retest

Flake

TheRealJon avatar Apr 15 '24 18:04 TheRealJon

/retest

TheRealJon avatar Apr 17 '24 13:04 TheRealJon

/retest

cluster install failed

TheRealJon avatar Apr 17 '24 14:04 TheRealJon

/retest

TheRealJon avatar Apr 17 '24 19:04 TheRealJon

After several rounds test against the pr, the copy login feature works as expected. If there is not further code update, I will add qe-approve label.

yanpzhan avatar Apr 23 '24 07:04 yanpzhan

/retest

jhadvig avatar Apr 24 '24 06:04 jhadvig

/lgtm

jhadvig avatar Apr 24 '24 06:04 jhadvig

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 24 '24 06:04 openshift-ci[bot]

The feature works against current code. /label qe-approved

yanpzhan avatar Apr 24 '24 06:04 yanpzhan

@TheRealJon: This pull request references CONSOLE-3902 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Add external OIDC copy login command modal to masthead toolbar and "Command Line Tools" page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 24 '24 06:04 openshift-ci-robot

/retest

jhadvig avatar Apr 24 '24 21:04 jhadvig

/retest-required

Remaining retests: 0 against base HEAD a0ef83f5fb3e5c173bcd6761b5512013a9fb67d7 and 2 for PR HEAD c6a9a728843e14978adfce65f5ee08085d9d6001 in total

openshift-ci-robot avatar Apr 24 '24 23:04 openshift-ci-robot

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 25 '24 03:04 openshift-ci[bot]