[WIP] CONSOLE-3902: External login command modal
Still a work in progress
@TheRealJon: This pull request references CONSOLE-3902 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Still a work in progress
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/retest
/label tide/merge-method-squash
@TheRealJon: This pull request references CONSOLE-3902 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Add external OIDC copy login command modal to masthead toolbar and "Command Line Tools" page.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
QE Approver /assign @yapei
Docs Approver: /assign @opayne1
PX Approver: /assign @RickJWagner
@jhadvig This PR is ready for review!
/label px-approved
/label docs-approved
/retest
Cluster install failed.
/retest
/retest
Flake
/retest
/retest
cluster install failed
/retest
After several rounds test against the pr, the copy login feature works as expected. If there is not further code update, I will add qe-approve label.
/retest
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, TheRealJon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~cmd/OWNERS~~ [TheRealJon,jhadvig]
- ~~frontend/OWNERS~~ [TheRealJon,jhadvig]
- ~~pkg/OWNERS~~ [TheRealJon,jhadvig]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The feature works against current code. /label qe-approved
@TheRealJon: This pull request references CONSOLE-3902 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Add external OIDC copy login command modal to masthead toolbar and "Command Line Tools" page.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest
/retest-required
Remaining retests: 0 against base HEAD a0ef83f5fb3e5c173bcd6761b5512013a9fb67d7 and 2 for PR HEAD c6a9a728843e14978adfce65f5ee08085d9d6001 in total
@TheRealJon: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.