openshift
OCPBUGS-26073: setting correct image trigger annotation
Fix: https://issues.redhat.com/browse/OCPBUGS-26073
Description:
We want to update trigger from auto to manual or vice versa. We can do it with CLI 'oc set triggers deployment/
https://github.com/openshift/console/assets/2561818/25287a9d-fd64-41cf-95f2-ce0bb994c36a
@vikram-raj: This pull request references Jira Issue OCPBUGS-26073, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Fix: https://issues.redhat.com/browse/OCPBUGS-26073
Description: We want to update trigger from auto to manual or vice versa. We can do it with CLI 'oc set triggers deployment/
--manual'. It normally changes to deployment annotation metadata.annotations.image.openshift.io/triggers to "paused: true" or "paused: false" when set to auto. But when we enable or disable auto trigger by editing deployment from the web console, it overrides annotation to "pause: false" or "pause: true" without 'd'. https://github.com/openshift/console/assets/2561818/25287a9d-fd64-41cf-95f2-ce0bb994c36a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@vikram-raj: This pull request references Jira Issue OCPBUGS-26073, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
value is not getting changed, it is always false if Auto deploy when new Image is available checkbox value is changed also.
https://github.com/openshift/console/assets/102503482/6dfa133b-b296-48fa-80a4-8d8bf168605b
value is not getting changed, it is always
falseif Auto deploy when new Image is available checkbox value is changed also.
paused value changes when the user changes the image of the deployment. Auto deploy checkbox select is not persist it looks like a different issue.
@vikram-raj: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tested locally. Annotation is getting set to paused instead of pause.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lokanandaprabhu, vikram-raj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/dev-console/OWNERS~~ [vikram-raj]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@vikram-raj: Jira Issue OCPBUGS-26073: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-26073 has been moved to the MODIFIED state.
In response to this:
Fix: https://issues.redhat.com/browse/OCPBUGS-26073
Description: We want to update trigger from auto to manual or vice versa. We can do it with CLI 'oc set triggers deployment/
--manual'. It normally changes to deployment annotation metadata.annotations.image.openshift.io/triggers to "paused: true" or "paused: false" when set to auto. But when we enable or disable auto trigger by editing deployment from the web console, it overrides annotation to "pause: false" or "pause: true" without 'd'. https://github.com/openshift/console/assets/2561818/25287a9d-fd64-41cf-95f2-ce0bb994c36a
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@vikram-raj: new pull request created: #13783
In response to this:
/cherry-pick release-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Fix included in accepted release 4.16.0-0.nightly-2024-04-21-123502
