openshift
OCPBUGS-10639: Switch to "verb kind" phrase so that Chinese translations do not have spaces between
@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-10639, which is invalid:
- expected Jira Issue OCPBUGS-10639 to depend on a bug targeting a version in 4.12.0, 4.12.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Follow on changes for Backported PR i18n rolebinding missing translations
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi @cyril-ui-developer the changes still not fixed the issue mentioned in bug, could you help to double-check?
Here is the pre-merge testing result:
Hi @cyril-ui-developer the changes still not fixed the issue mentioned in bug, could you help to double-check? Here is the pre-merge testing result:
@XiyunZhao Hmm, sure I will.
XiyunZhao
@XiyunZhao I am still investigating this issue. Seems I am seeing unexpected behavior for Chinese translations for the RoleBindings action menu. It shows the correct translations for a while, then change to something else later. Would have to investigate this further.
XiyunZhao
@XiyunZhao I am still investigating this issue. Seems I am seeing unexpected behavior for Chinese translations for the RoleBindings action menu. It shows the correct translations for a while, then change to something else later. Would have to investigate this further.
Never mind, I think I figured out the issue.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cyril-ui-developer Once this PR has been reviewed and has the lgtm label, please ask for approval from jhadvig. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
XiyunZhao
@XiyunZhao I am still investigating this issue. Seems I am seeing unexpected behavior for Chinese translations for the RoleBindings action menu. It shows the correct translations for a while, then change to something else later. Would have to investigate this further.
Never mind, I think I figured out the issue.
Updated. PTAL
Screenshots:
@cyril-ui-developer: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-10639. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.
In response to this:
Follow on changes for i18n rolebinding missing translations Backported PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.