console icon indicating copy to clipboard operation
console copied to clipboard

[WIP] CONSOLE-3668: TS typing related fixes

Open raspbeep opened this issue 1 year ago • 20 comments

  • [x] avoid using types which are not recommended as per @typescript-eslint/ban-types docs

  • [ ] use better react-redux types to avoid @ts-ignore suppressions when importing APIs from that package

  • [ ] fix typecast to any for kmsProvider in packages/ceph-storage-plugin/src/components/kms-config/kms-config.tsx (may indicate a bug in our type definitions)

  • [ ] useSelector and useDispatch code locations as part of typescript bump

raspbeep avatar Sep 08 '23 14:09 raspbeep

@raspbeep: This pull request references CONSOLE-3668 which is a valid jira issue.

In response to this:

  • [] avoid using types which are not recommended as per @typescript-eslint/ban-types docs

  • [ ] use better react-redux types to avoid @ts-ignore suppressions when importing APIs from that package

  • [ ] useSelector and useDispatch code locations as part of typescript bump

  • [ ] fix typecast to any for kmsProvider in packages/ceph-storage-plugin/src/components/kms-config/kms-config.tsx (may indicate a bug in our type definitions)

  • [ ] ceph storage plugin may become a dynamic plugin and thus not be needed. this decision is pending.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Sep 08 '23 14:09 openshift-ci-robot

@raspbeep: This pull request references CONSOLE-3668 which is a valid jira issue.

In response to this:

  • [ ] avoid using types which are not recommended as per @typescript-eslint/ban-types docs

  • [ ] use better react-redux types to avoid @ts-ignore suppressions when importing APIs from that package

  • [ ] useSelector and useDispatch code locations as part of typescript bump

  • [ ] fix typecast to any for kmsProvider in packages/ceph-storage-plugin/src/components/kms-config/kms-config.tsx (may indicate a bug in our type definitions)

  • [ ] ceph storage plugin may become a dynamic plugin and thus not be needed. this decision is pending

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Sep 08 '23 14:09 openshift-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raspbeep Once this PR has been reviewed and has the lgtm label, please assign vikram-raj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 08 '23 14:09 openshift-ci[bot]

Hi @raspbeep. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 08 '23 14:09 openshift-ci[bot]

@raspbeep: This pull request references CONSOLE-3668 which is a valid jira issue.

In response to this:

  • [x] avoid using types which are not recommended as per @typescript-eslint/ban-types docs

  • [ ] use better react-redux types to avoid @ts-ignore suppressions when importing APIs from that package

  • [ ] useSelector and useDispatch code locations as part of typescript bump

  • [ ] fix typecast to any for kmsProvider in packages/ceph-storage-plugin/src/components/kms-config/kms-config.tsx (may indicate a bug in our type definitions)

  • [ ] ceph storage plugin may become a dynamic plugin and thus not be needed. this decision is pending

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Sep 08 '23 14:09 openshift-ci-robot

@raspbeep: This pull request references CONSOLE-3668 which is a valid jira issue.

In response to this:

  • [ ] avoid using types which are not recommended as per @typescript-eslint/ban-types docs

  • [ ] use better react-redux types to avoid @ts-ignore suppressions when importing APIs from that package

  • [ ] useSelector and useDispatch code locations as part of typescript bump

  • [ ] fix typecast to any for kmsProvider in packages/ceph-storage-plugin/src/components/kms-config/kms-config.tsx (may indicate a bug in our type definitions)

  • [ ] ceph storage plugin may become a dynamic plugin and thus not be needed. this decision is pending

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Sep 08 '23 14:09 openshift-ci-robot

@raspbeep: This pull request references CONSOLE-3668 which is a valid jira issue.

In response to this:

  • [x] avoid using types which are not recommended as per @typescript-eslint/ban-types docs

  • [ ] use better react-redux types to avoid @ts-ignore suppressions when importing APIs from that package

  • [ ] useSelector and useDispatch code locations as part of typescript bump

  • [ ] fix typecast to any for kmsProvider in packages/ceph-storage-plugin/src/components/kms-config/kms-config.tsx (may indicate a bug in our type definitions)

  • [ ] ceph storage plugin may become a dynamic plugin and thus not be needed. this decision is pending

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Sep 08 '23 14:09 openshift-ci-robot

@raspbeep: This pull request references CONSOLE-3668 which is a valid jira issue.

In response to this:

  • [ ] avoid using types which are not recommended as per @typescript-eslint/ban-types docs

  • [ ] use better react-redux types to avoid @ts-ignore suppressions when importing APIs from that package

  • [ ] useSelector and useDispatch code locations as part of typescript bump

  • [ ] fix typecast to any for kmsProvider in packages/ceph-storage-plugin/src/components/kms-config/kms-config.tsx (may indicate a bug in our type definitions)

  • [ ] ceph storage plugin may become a dynamic plugin and thus not be needed. this decision is pending

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Sep 08 '23 14:09 openshift-ci-robot

/ok-to-test

jhadvig avatar Sep 08 '23 15:09 jhadvig

@raspbeep: This pull request references CONSOLE-3668 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

  • [x] avoid using types which are not recommended as per @typescript-eslint/ban-types docs

  • [ ] use better react-redux types to avoid @ts-ignore suppressions when importing APIs from that package

  • [ ] useSelector and useDispatch code locations as part of typescript bump

  • [ ] fix typecast to any for kmsProvider in packages/ceph-storage-plugin/src/components/kms-config/kms-config.tsx (may indicate a bug in our type definitions)

  • [ ] ceph storage plugin may become a dynamic plugin and thus not be needed. this decision is pending

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Sep 18 '23 08:09 openshift-ci-robot

@raspbeep: This pull request references CONSOLE-3668 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

  • [x] avoid using types which are not recommended as per @typescript-eslint/ban-types docs

  • [ ] use better react-redux types to avoid @ts-ignore suppressions when importing APIs from that package

  • [ ] useSelector and useDispatch code locations as part of typescript bump

  • [ ] fix typecast to any for kmsProvider in packages/ceph-storage-plugin/src/components/kms-config/kms-config.tsx (may indicate a bug in our type definitions)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Sep 18 '23 08:09 openshift-ci-robot

@raspbeep: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend 82f6a8d0b307021a639476f6792320f3737ed2f8 link true /test frontend

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 18 '23 11:09 openshift-ci[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Sep 30 '23 13:09 openshift-merge-robot

@raspbeep: This pull request references CONSOLE-3668 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

  • [x] avoid using types which are not recommended as per @typescript-eslint/ban-types docs

  • [ ] use better react-redux types to avoid @ts-ignore suppressions when importing APIs from that package

  • [ ] useSelector and useDispatch code locations as part of typescript bump

  • [ ] fix typecast to any for kmsProvider in packages/ceph-storage-plugin/src/components/kms-config/kms-config.tsx (may indicate a bug in our type definitions)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Sep 30 '23 13:09 openshift-ci-robot

@raspbeep: This pull request references CONSOLE-3668 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

  • [x] avoid using types which are not recommended as per @typescript-eslint/ban-types docs

  • [ ] use better react-redux types to avoid @ts-ignore suppressions when importing APIs from that package

  • [ ] fix typecast to any for kmsProvider in packages/ceph-storage-plugin/src/components/kms-config/kms-config.tsx (may indicate a bug in our type definitions)

  • [ ] useSelector and useDispatch code locations as part of typescript bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Oct 18 '23 12:10 openshift-ci-robot

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jan 17 '24 01:01 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Feb 16 '24 08:02 openshift-bot

Hi @raspbeep, Could you help to rebase this PR?

XiyunZhao avatar Mar 01 '24 02:03 XiyunZhao

@raspbeep any update?

XiyunZhao avatar Mar 13 '24 02:03 XiyunZhao

Hi @raspbeep Could you help on the rebase? cc: @jhadvig

XiyunZhao avatar Mar 18 '24 01:03 XiyunZhao

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Apr 17 '24 08:04 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 17 '24 08:04 openshift-ci[bot]