console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.11] OCPBUGS-2515:Change annotation to be used for fake helm repositories

Open openshift-cherrypick-robot opened this issue 2 years ago • 7 comments

This is an automated cherry-pick of #12141

/assign Kartikey-star

@openshift-cherrypick-robot: Jira Issue OCPBUGS-2344 has been cloned as Jira Issue OCPBUGS-2515. Retitling PR to link against new bug. /retitle [release-4.11] OCPBUGS-2515:Change annotation to be used for fake helm repositories

In response to this:

This is an automated cherry-pick of #12141

/assign Kartikey-star

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Oct 18 '22 13:10 openshift-ci-robot

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-2515:Change annotation to be used for fake helm repositories

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 18 '22 13:10 openshift-ci[bot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-2515, which is invalid:

  • expected dependent Jira Issue OCPBUGS-2344 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #12141

/assign Kartikey-star

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Oct 18 '22 13:10 openshift-ci-robot

/jira refresh

Kartikey-star avatar Oct 18 '22 13:10 Kartikey-star

@Kartikey-star: This pull request references Jira Issue OCPBUGS-2515, which is invalid:

  • expected dependent Jira Issue OCPBUGS-2344 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Oct 18 '22 13:10 openshift-ci-robot

/retest

Kartikey-star avatar Oct 20 '22 03:10 Kartikey-star

/retest

Kartikey-star avatar Oct 20 '22 05:10 Kartikey-star

/assign @jhadvig

Jakub, this change is to get an error string returned from the helm backend when it can not access one or more helm chart repos. @debsmita1 is working on frontend code that will show this annotation and we will backport this as well.

christoph-jerolimov avatar Oct 20 '22 21:10 christoph-jerolimov

@jerolimov the frontend code will be also backported ?

jhadvig avatar Oct 21 '22 08:10 jhadvig

@jhadvig Yes (it's not part of master yet, it's WIP, but we will backport it as well)

christoph-jerolimov avatar Oct 21 '22 08:10 christoph-jerolimov

/jira-refresh

Kartikey-star avatar Oct 21 '22 09:10 Kartikey-star

/jira refresh

Kartikey-star avatar Oct 21 '22 09:10 Kartikey-star

@Kartikey-star: This pull request references Jira Issue OCPBUGS-2515, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-2344 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-2344 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Oct 21 '22 09:10 openshift-ci-robot

/approve

Kartikey-star avatar Oct 21 '22 12:10 Kartikey-star

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, jhadvig, Kartikey-star, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 24 '22 07:10 openshift-ci[bot]

This PR has been tested with private build (launch 4.11.0-0.nightly-2022-10-24-182851,openshift/console#12182) Verification Step:

  1. Login OCP as administrator
  2. Go to developer perspective -> Helm page
  3. Create a fake help repository (Click "Install a Helm Chart from the developer catalog" -> Click the link of "try to configure their own custom Helm Chart repository." on Helm Charts page -> provide name: testhelm and URL: http://github.test.com as an example)
  4. Go back to Helm Chart page again
  5. Check the API response on the Network of the Browser
  6. Re-login OCP as a normal user, do steps 2-5 again Result:
  7. A request could be caught by the Network of Browser, and the annotations of "console-waring: The following repositories seem to be invalid or unreachable:" would be found on the Response image

/label qe-approved

XiyunZhao avatar Oct 25 '22 06:10 XiyunZhao

/label cherry-pick-approved

yapei avatar Oct 25 '22 06:10 yapei

/retest

Kartikey-star avatar Oct 25 '22 11:10 Kartikey-star

/retest

Kartikey-star avatar Oct 25 '22 14:10 Kartikey-star

/retest

Kartikey-star avatar Oct 26 '22 00:10 Kartikey-star

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 26 '22 04:10 openshift-ci[bot]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2515 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #12141

/assign Kartikey-star

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Oct 26 '22 04:10 openshift-ci-robot