OCPBUGS-2430: Add missing Quick Start translation

[christoph-jerolimov]

Fixes: https://issues.redhat.com/browse/OCPBUGS-2430

Analysis / Root cause: @invincibleJai reported in the customization form code review https://github.com/openshift/console/pull/12159#issuecomment-1277503421 that nothing is rendered when no Quick Start is found or all Quick Starts are disabled. While debugging I noticed that the PatternFly component handles this already:

https://github.com/patternfly/patternfly-quickstarts/blob/e7ddc87bb040733029c0f5be7873542b41d4871e/packages/module/src/QuickStartCatalogPage.tsx#L156-L158

https://github.com/patternfly/patternfly-quickstarts/blob/e7ddc87bb040733029c0f5be7873542b41d4871e/packages/module/src/ConsoleInternal/components/utils/status-box.tsx#L26-L38

But it doesn't render anything. The underlying issue is that the translations for "No {{label}} found" was found. PF QuickStarts doesn't show anything in this case. I opened a ticket that this should return the not translated version in that case: https://github.com/patternfly/patternfly-quickstarts/pull/194

Solution Description: To fix this on our side, and also to translate these values I've added some missed Quick Start strings.

Just searched for getResource calls in https://github.com/patternfly/patternfly-quickstarts

Screenshots:

Before when no Quick Starts were found:

With this PR when no Quick Starts were found:

Other languages will not show anything until the translation is added or https://github.com/patternfly/patternfly-quickstarts/pull/194 is fixed/merged.

Before with missing translation in the sidebar:

With this PR:

No Quick start flicker with new translation, but without changes at the loaded state:

https://user-images.githubusercontent.com/139310/195959065-071fe39a-f01c-4fa8-a1dd-99490897196c.mp4

With updated loading/loaded state:

https://user-images.githubusercontent.com/139310/195959070-82dd11a7-bbd4-4d21-a208-508c7d1bdddb.mp4

Unit test coverage report: Unchanged

Test setup: Disable all quick starts, on a local bridge you need to create the config.yaml manually and start the bridge like this:

bin/bridge -config ../config.yaml

apiVersion: console.openshift.io/v1
kind: ConsoleConfig
customization:
  quickStarts:
    disabled:
      - "quarkus-with-s2i"
      - "spring-with-s2i"
      - "monitor-sampleapp"
      - "install-app-and-associate-pipeline"
      - "odf-install-tour"
      - "quarkus-with-helm"
      - "sample-application"
      - "node-with-s2i"
      - "install-serverless"
      - "install-helmchartrepo-ns"
      - "add-healthchecks"
      - "explore-pipelines"
      - "manage-helm-repos"
      - "configure-pipeline-metrics"

Browser conformance:

• [x] Chrome
• [ ] Firefox
• [ ] Safari
• [ ] Edge

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-2430, which is invalid:

• expected the bug to target only the "4.12.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: todo

Analysis / Root cause: @invincibleJai reported in the customization form code review https://github.com/openshift/console/pull/12159#issuecomment-1277503421 that nothing is rendered when no Quick Start is found or all Quick Starts are disabled. While debugging I noticed that the PatternFly component handles this already:

https://github.com/patternfly/patternfly-quickstarts/blob/e7ddc87bb040733029c0f5be7873542b41d4871e/packages/module/src/QuickStartCatalogPage.tsx#L156-L158

https://github.com/patternfly/patternfly-quickstarts/blob/e7ddc87bb040733029c0f5be7873542b41d4871e/packages/module/src/ConsoleInternal/components/utils/status-box.tsx#L26-L38

But it doesn't render anything. The underlying issue is that the translations for "No {{label}} found" was found. PF QuickStarts doesn't show anything in this case. I opened a ticket that this should return the not translated version in that case: https://github.com/patternfly/patternfly-quickstarts/pull/194

Solution Description: To fix this on our side, and also to translate these values I've added some missed Quick Start strings.

Just searched for getResource calls in https://github.com/patternfly/patternfly-quickstarts

Screenshots:

Before:

After:

Unit test coverage report: Unchanged

Test setup: Disable all quick starts, on a local bridge you need to create the config.yaml manually and start the bridge like this:

bin/bridge -config ../config.yaml

apiVersion: console.openshift.io/v1
kind: ConsoleConfig
 quickStarts:
   disabled:
     - "quarkus-with-s2i"
     - "spring-with-s2i"
     - "monitor-sampleapp"
     - "install-app-and-associate-pipeline"
     - "odf-install-tour"
     - "quarkus-with-helm"
     - "sample-application"
     - "node-with-s2i"
     - "install-serverless"
     - "install-helmchartrepo-ns"
     - "add-healthchecks"
     - "explore-pipelines"
     - "manage-helm-repos"
     - "configure-pipeline-metrics"

Browser conformance:

• [x] Chrome
• [ ] Firefox
• [ ] Safari
• [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-2430, which is invalid:

• expected the bug to target only the "4.12.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-2430

Analysis / Root cause: @invincibleJai reported in the customization form code review https://github.com/openshift/console/pull/12159#issuecomment-1277503421 that nothing is rendered when no Quick Start is found or all Quick Starts are disabled. While debugging I noticed that the PatternFly component handles this already:

https://github.com/patternfly/patternfly-quickstarts/blob/e7ddc87bb040733029c0f5be7873542b41d4871e/packages/module/src/QuickStartCatalogPage.tsx#L156-L158

https://github.com/patternfly/patternfly-quickstarts/blob/e7ddc87bb040733029c0f5be7873542b41d4871e/packages/module/src/ConsoleInternal/components/utils/status-box.tsx#L26-L38

But it doesn't render anything. The underlying issue is that the translations for "No {{label}} found" was found. PF QuickStarts doesn't show anything in this case. I opened a ticket that this should return the not translated version in that case: https://github.com/patternfly/patternfly-quickstarts/pull/194

Solution Description: To fix this on our side, and also to translate these values I've added some missed Quick Start strings.

Just searched for getResource calls in https://github.com/patternfly/patternfly-quickstarts

Screenshots:

Before when no Quick Starts were found:

With this PR when no Quick Starts were found:

Before with missing translation in the sidebar:

With this PR:

No Quick start flicker with new translation, but without changes at the loaded state:

https://user-images.githubusercontent.com/139310/195959065-071fe39a-f01c-4fa8-a1dd-99490897196c.mp4

With updated loading/loaded state:

https://user-images.githubusercontent.com/139310/195959070-82dd11a7-bbd4-4d21-a208-508c7d1bdddb.mp4

Unit test coverage report: Unchanged

Test setup: Disable all quick starts, on a local bridge you need to create the config.yaml manually and start the bridge like this:

bin/bridge -config ../config.yaml

apiVersion: console.openshift.io/v1
kind: ConsoleConfig
 quickStarts:
   disabled:
     - "quarkus-with-s2i"
     - "spring-with-s2i"
     - "monitor-sampleapp"
     - "install-app-and-associate-pipeline"
     - "odf-install-tour"
     - "quarkus-with-helm"
     - "sample-application"
     - "node-with-s2i"
     - "install-serverless"
     - "install-helmchartrepo-ns"
     - "add-healthchecks"
     - "explore-pipelines"
     - "manage-helm-repos"
     - "configure-pipeline-metrics"

Browser conformance:

• [x] Chrome
• [ ] Firefox
• [ ] Safari
• [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[christoph-jerolimov]

/jira refresh /kind bug /uncc kyoto cyril-ui-developer /cc @invincibleJai @debsmita1

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-2430, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.0) matches configured target version for branch (4.12.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh /kind bug /uncc kyoto cyril-ui-developer /cc @invincibleJai @debsmita1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-2430, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.0) matches configured target version for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-2430

Analysis / Root cause: @invincibleJai reported in the customization form code review https://github.com/openshift/console/pull/12159#issuecomment-1277503421 that nothing is rendered when no Quick Start is found or all Quick Starts are disabled. While debugging I noticed that the PatternFly component handles this already:

https://github.com/patternfly/patternfly-quickstarts/blob/e7ddc87bb040733029c0f5be7873542b41d4871e/packages/module/src/QuickStartCatalogPage.tsx#L156-L158

https://github.com/patternfly/patternfly-quickstarts/blob/e7ddc87bb040733029c0f5be7873542b41d4871e/packages/module/src/ConsoleInternal/components/utils/status-box.tsx#L26-L38

But it doesn't render anything. The underlying issue is that the translations for "No {{label}} found" was found. PF QuickStarts doesn't show anything in this case. I opened a ticket that this should return the not translated version in that case: https://github.com/patternfly/patternfly-quickstarts/pull/194

Solution Description: To fix this on our side, and also to translate these values I've added some missed Quick Start strings.

Just searched for getResource calls in https://github.com/patternfly/patternfly-quickstarts

Screenshots:

Before when no Quick Starts were found:

With this PR when no Quick Starts were found:

Other languages will not show anything until the translation is added or https://github.com/patternfly/patternfly-quickstarts/pull/194 is fixed/merged.

Before with missing translation in the sidebar:

With this PR:

No Quick start flicker with new translation, but without changes at the loaded state:

https://user-images.githubusercontent.com/139310/195959065-071fe39a-f01c-4fa8-a1dd-99490897196c.mp4

With updated loading/loaded state:

https://user-images.githubusercontent.com/139310/195959070-82dd11a7-bbd4-4d21-a208-508c7d1bdddb.mp4

Unit test coverage report: Unchanged

Test setup: Disable all quick starts, on a local bridge you need to create the config.yaml manually and start the bridge like this:

bin/bridge -config ../config.yaml

apiVersion: console.openshift.io/v1
kind: ConsoleConfig
 quickStarts:
   disabled:
     - "quarkus-with-s2i"
     - "spring-with-s2i"
     - "monitor-sampleapp"
     - "install-app-and-associate-pipeline"
     - "odf-install-tour"
     - "quarkus-with-helm"
     - "sample-application"
     - "node-with-s2i"
     - "install-serverless"
     - "install-helmchartrepo-ns"
     - "add-healthchecks"
     - "explore-pipelines"
     - "manage-helm-repos"
     - "configure-pipeline-metrics"

Browser conformance:

• [x] Chrome
• [ ] Firefox
• [ ] Safari
• [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-2430, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.0) matches configured target version for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-2430

Analysis / Root cause: @invincibleJai reported in the customization form code review https://github.com/openshift/console/pull/12159#issuecomment-1277503421 that nothing is rendered when no Quick Start is found or all Quick Starts are disabled. While debugging I noticed that the PatternFly component handles this already:

https://github.com/patternfly/patternfly-quickstarts/blob/e7ddc87bb040733029c0f5be7873542b41d4871e/packages/module/src/QuickStartCatalogPage.tsx#L156-L158

https://github.com/patternfly/patternfly-quickstarts/blob/e7ddc87bb040733029c0f5be7873542b41d4871e/packages/module/src/ConsoleInternal/components/utils/status-box.tsx#L26-L38

But it doesn't render anything. The underlying issue is that the translations for "No {{label}} found" was found. PF QuickStarts doesn't show anything in this case. I opened a ticket that this should return the not translated version in that case: https://github.com/patternfly/patternfly-quickstarts/pull/194

Solution Description: To fix this on our side, and also to translate these values I've added some missed Quick Start strings.

Just searched for getResource calls in https://github.com/patternfly/patternfly-quickstarts

Screenshots:

Before when no Quick Starts were found:

With this PR when no Quick Starts were found:

Other languages will not show anything until the translation is added or https://github.com/patternfly/patternfly-quickstarts/pull/194 is fixed/merged.

Before with missing translation in the sidebar:

With this PR:

No Quick start flicker with new translation, but without changes at the loaded state:

https://user-images.githubusercontent.com/139310/195959065-071fe39a-f01c-4fa8-a1dd-99490897196c.mp4

With updated loading/loaded state:

https://user-images.githubusercontent.com/139310/195959070-82dd11a7-bbd4-4d21-a208-508c7d1bdddb.mp4

Unit test coverage report: Unchanged

Test setup: Disable all quick starts, on a local bridge you need to create the config.yaml manually and start the bridge like this:

bin/bridge -config ../config.yaml

apiVersion: console.openshift.io/v1
kind: ConsoleConfig
customization:
 quickStarts:
   disabled:
     - "quarkus-with-s2i"
     - "spring-with-s2i"
     - "monitor-sampleapp"
     - "install-app-and-associate-pipeline"
     - "odf-install-tour"
     - "quarkus-with-helm"
     - "sample-application"
     - "node-with-s2i"
     - "install-serverless"
     - "install-helmchartrepo-ns"
     - "add-healthchecks"
     - "explore-pipelines"
     - "manage-helm-repos"
     - "configure-pipeline-metrics"

Browser conformance:

• [x] Chrome
• [ ] Firefox
• [ ] Safari
• [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[christoph-jerolimov]

/retest

[openshift-ci[bot]]

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[invincibleJai]

Thanks @jerolimov this looks good,

would have liked to see empty state with page heading but i see here in pf it just returns EmptyBox https://github.com/patternfly/patternfly-quickstarts/blob/c00e128724d4ae31f6ee22bf369810f27f929243/packages/module/src/QuickStartCatalogPage.tsx#L156-L158

[invincibleJai]

/lgtm

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~frontend/OWNERS~~ [invincibleJai,jerolimov]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jerolimov: All pull requests linked via external trackers have merged:

• openshift/console#12171

Jira Issue OCPBUGS-2430 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-2430

Analysis / Root cause: @invincibleJai reported in the customization form code review https://github.com/openshift/console/pull/12159#issuecomment-1277503421 that nothing is rendered when no Quick Start is found or all Quick Starts are disabled. While debugging I noticed that the PatternFly component handles this already:

https://github.com/patternfly/patternfly-quickstarts/blob/e7ddc87bb040733029c0f5be7873542b41d4871e/packages/module/src/QuickStartCatalogPage.tsx#L156-L158

https://github.com/patternfly/patternfly-quickstarts/blob/e7ddc87bb040733029c0f5be7873542b41d4871e/packages/module/src/ConsoleInternal/components/utils/status-box.tsx#L26-L38

But it doesn't render anything. The underlying issue is that the translations for "No {{label}} found" was found. PF QuickStarts doesn't show anything in this case. I opened a ticket that this should return the not translated version in that case: https://github.com/patternfly/patternfly-quickstarts/pull/194

Solution Description: To fix this on our side, and also to translate these values I've added some missed Quick Start strings.

Just searched for getResource calls in https://github.com/patternfly/patternfly-quickstarts

Screenshots:

Before when no Quick Starts were found:

With this PR when no Quick Starts were found:

Other languages will not show anything until the translation is added or https://github.com/patternfly/patternfly-quickstarts/pull/194 is fixed/merged.

Before with missing translation in the sidebar:

With this PR:

No Quick start flicker with new translation, but without changes at the loaded state:

https://user-images.githubusercontent.com/139310/195959065-071fe39a-f01c-4fa8-a1dd-99490897196c.mp4

With updated loading/loaded state:

https://user-images.githubusercontent.com/139310/195959070-82dd11a7-bbd4-4d21-a208-508c7d1bdddb.mp4

Unit test coverage report: Unchanged

Test setup: Disable all quick starts, on a local bridge you need to create the config.yaml manually and start the bridge like this:

bin/bridge -config ../config.yaml

apiVersion: console.openshift.io/v1
kind: ConsoleConfig
customization:
 quickStarts:
   disabled:
     - "quarkus-with-s2i"
     - "spring-with-s2i"
     - "monitor-sampleapp"
     - "install-app-and-associate-pipeline"
     - "odf-install-tour"
     - "quarkus-with-helm"
     - "sample-application"
     - "node-with-s2i"
     - "install-serverless"
     - "install-helmchartrepo-ns"
     - "add-healthchecks"
     - "explore-pipelines"
     - "manage-helm-repos"
     - "configure-pipeline-metrics"

Browser conformance:

• [x] Chrome
• [ ] Firefox
• [ ] Safari
• [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.