console
console copied to clipboard
openshift
CONSOLE-3276: Expose ErrorBoundary capabilities in the SDK
Addresses: https://issues.redhat.com/browse/CONSOLE-3276
The console has good error boundary components that are useful for dynamic plugin. Exposing them will enable the plugins to get the same look and feel of handling react errors as console The minimum requirement right now is to expose the ErrorBoundaryFallbackPage component from https://github.com/openshift/console/blob/master/frontend/packages/console-shared/src/components/error/fallbacks/ErrorBoundaryFallbackPage.tsx
Exposed ErrorBoundaryFallbackPage in this pr. We could add additional error boundary components in later pr's if that is something that is desired.
Added a test page in the Demo Dynamic Plugin to test the ErrorBoundaryFallbackPage as well.
Thanks @jhadvig made updates from review if you think its ready please tag.
QE Approver: /assign @yapei
Docs Approver: /assign @opayne1
PX Approver: /assign @RickJWagner
Console Approver: /assign @jhadvig
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jcaianirh, jhadvig
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~dynamic-demo-plugin/OWNERS~~ [jhadvig]
- ~~frontend/OWNERS~~ [jhadvig]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jcaianirh, jhadvig
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~dynamic-demo-plugin/OWNERS~~ [jhadvig]
- ~~frontend/OWNERS~~ [jhadvig]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
tested the PR and confirmed that the 'Sample Error Boundary Page' is working as expected /label qe-approved
