console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.10] Bug 2090127: Remove nodeSelectorTerms if not defined

Open upalatucci opened this issue 2 years ago • 16 comments

Don't add nodeSelectorTerms key in affinity under AffinityCondition.required if the list is empty

upalatucci avatar Oct 12 '22 13:10 upalatucci

@upalatucci: This pull request references Bugzilla bug 2090127, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.z) matches configured target release for branch (4.10.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2079674 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2079674 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact: /cc @gouyang

In response to this:

[release-4.10] Bug 2090127: Remove nodeSelectorTerms if not defined

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 12 '22 13:10 openshift-ci[bot]

/retest

upalatucci avatar Oct 12 '22 16:10 upalatucci

/retest

upalatucci avatar Oct 12 '22 18:10 upalatucci

/label cherry-pick-approved

gouyang avatar Oct 13 '22 01:10 gouyang

/retest

upalatucci avatar Oct 13 '22 09:10 upalatucci

/lgtm

pcbailey avatar Oct 13 '22 11:10 pcbailey

/retest

pcbailey avatar Oct 13 '22 11:10 pcbailey

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 13 '22 11:10 openshift-ci[bot]

/retest

upalatucci avatar Oct 13 '22 15:10 upalatucci

/retest

upalatucci avatar Oct 13 '22 18:10 upalatucci

/retest

upalatucci avatar Oct 14 '22 07:10 upalatucci

/retest

upalatucci avatar Oct 17 '22 09:10 upalatucci

/retest

upalatucci avatar Oct 17 '22 13:10 upalatucci

/retest

upalatucci avatar Oct 18 '22 05:10 upalatucci

/retest

upalatucci avatar Oct 18 '22 09:10 upalatucci

/retest

gouyang avatar Oct 26 '22 09:10 gouyang

/retest

upalatucci avatar Oct 28 '22 14:10 upalatucci

/label backport-risk-assessed

yaacov avatar Oct 28 '22 14:10 yaacov

/retest

gouyang avatar Oct 31 '22 08:10 gouyang

@upalatucci: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 31 '22 13:10 openshift-ci[bot]

@upalatucci: All pull requests linked via external trackers have merged:

Bugzilla bug 2090127 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2090127: Remove nodeSelectorTerms if not defined

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 31 '22 13:10 openshift-ci[bot]