console
console copied to clipboard
openshift
ODC-7130: Show focus border on pipeline run nodes
Fixes: Fixes ODC-7130
Analysis / Root cause:
PF sets the focus border to be hidden on all
Solution Description:
Add styling to show the focus border on the task nodes. Restructure the pieces of the node so they remain under the Layer.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jeff-phillips-18, vikram-raj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/pipelines-plugin/OWNERS~~ [vikram-raj]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jeff-phillips-18: This pull request references Jira Issue OCPBUGS-2651, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.12.0) matches configured target version for branch (4.12.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Fixes: Fixes ODC-7130
Analysis / Root cause: PF sets the focus border to be hidden on all
elements. Updating the layer on hover/focus causes elements to lose focus shortly after gaining it. Solution Description: Add styling to show the focus border on the task nodes. Restructure the pieces of the node so they remain under the
Layer.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jeff-phillips-18 i couldn't verify it, am on mac, chrome Version 106.0.5249.119
I couldn't see the outline working, check the below gif
cc @vikram-raj
@invincibleJai Is there a reason to have focus on nodes that are not selectable? I've only added the focus border to the pipeline runs since those nodes are clickable to show details.
@invincibleJai There was no previous focus on the pipeline details tasks. Since they are not clickable there is no need for focus.
@invincibleJai There was no previous focus on the pipeline details tasks. Since they are not
clickablethere is no need for focus.
sorry my bad, I missed that. Thanks for the update
@jeff-phillips-18: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@jeff-phillips-18: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-2651 has been moved to the MODIFIED state.
In response to this:
Fixes: Fixes ODC-7130
Analysis / Root cause: PF sets the focus border to be hidden on all
elements. Updating the layer on hover/focus causes elements to lose focus shortly after gaining it. Solution Description: Add styling to show the focus border on the task nodes. Restructure the pieces of the node so they remain under the
Layer.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.