openshift
OCPBUGS-1598: updates toast wording to Workload
@invincibleJai: This pull request references Jira Issue OCPBUGS-1598, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.12.0) matches configured target version for branch (4.12.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Tracks: https://issues.redhat.com/browse/OCPBUGS-1598
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: invincibleJai
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/dev-console/OWNERS~~ [invincibleJai]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@invincibleJai: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Works fine, but I have two concerns I would recommend to improve or check with @serenamarie125 or UX if we want continue with the current solution.
a) The
Routelink in the toast is not shown for Knative Services.Sure, it\s an improvement to show the modal, but we added this toast to make it easier to open the application (component) directly.
And with defaulting to Serverless Services we should also show links for this.
One implementation option might be to add a watcher in
ImportToastContentif thedeployedResource(see also below) is a KnativeService.
Yeah I was hoping this can be handled with a separate issue as ksvc route is not like the k8s route which we create as resources with import flow for Deployment and DC so will need some more work on it. Let's discuss on it.
b) Term workload
Also if I added this suggestion to the issue, I'm unsure if we w use the term Workload here or if we should rephrase it to:
Resource created successfully.or:
Component created successfully.or IMHO even better:
${resourceKind} ${resourceName} created successfully.From the implementation point of view this should be possible if we just pass one
deployedResourcetoImportToastContentand pass the first Deployment / DeploymentConfig or Knative Service. (Changingresources.filtertoresources.find)Wdyt?
We can do whatever way we would like to go in current logic the check is to see if the deployed resource is one or more, am not sure in which scenario it'll be more (in the current import flow) so we can show it as above for the case when the deployed resource is 1.
/retest-required
Remaining retests: 0 against base HEAD c30f30442e83d788d74714c3871c78398e822917 and 2 for PR HEAD 9eb88a667e1805d62ee84c382c6aa0972f557521 in total
/retest-required
Remaining retests: 0 against base HEAD dcc5d9d3e8ec63ab5d29055c0ebbb64f7c1ecc90 and 1 for PR HEAD 9eb88a667e1805d62ee84c382c6aa0972f557521 in total
@invincibleJai: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: invincibleJai, jerolimov, vikram-raj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/dev-console/OWNERS~~ [invincibleJai,jerolimov,vikram-raj]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jerolimov: #12155 failed to apply on top of branch "release-4.12":
Applying: updates toast wording to Workload
Using index info to reconstruct a base tree...
M frontend/packages/dev-console/locales/en/devconsole.json
M frontend/packages/dev-console/src/components/import/ImportForm.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/components/import/ImportForm.tsx
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/import/ImportForm.tsx
Auto-merging frontend/packages/dev-console/locales/en/devconsole.json
CONFLICT (content): Merge conflict in frontend/packages/dev-console/locales/en/devconsole.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 updates toast wording to Workload
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherry-pick release-4.12
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
